From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Kevin Ryde Newsgroups: gmane.lisp.guile.devel Subject: Re: GMP code committed -- watch for bugs ... gcd n 0 Date: Sat, 10 May 2003 10:22:27 +1000 Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Message-ID: <87he83tzuk.fsf_-_@zip.com.au> References: <87he9dhoxh.fsf@raven.i.defaultvalue.org> <87wui76y0t.fsf@zip.com.au> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1052526501 9738 80.91.224.249 (10 May 2003 00:28:21 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sat, 10 May 2003 00:28:21 +0000 (UTC) Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sat May 10 02:28:20 2003 Return-path: Original-Received: from monty-python.gnu.org ([199.232.76.173]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19EIDr-0002Wv-00 for ; Sat, 10 May 2003 02:28:20 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 19EIF0-0007Uc-00 for guile-devel@m.gmane.org; Fri, 09 May 2003 20:29:30 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 19EIEh-0007Ns-00 for guile-devel@gnu.org; Fri, 09 May 2003 20:29:11 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 19EIEf-0007Mv-00 for guile-devel@gnu.org; Fri, 09 May 2003 20:29:10 -0400 Original-Received: from snoopy.pacific.net.au ([61.8.0.36]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 19EIEe-0007Ih-00 for guile-devel@gnu.org; Fri, 09 May 2003 20:29:09 -0400 Original-Received: from sunny.pacific.net.au (sunny.pacific.net.au [203.2.228.40]) h4A0T5Pc009176 for ; Sat, 10 May 2003 10:29:05 +1000 Original-Received: from wisma.pacific.net.au (wisma.pacific.net.au [210.23.129.72]) by sunny.pacific.net.au with ESMTP id h4A0T5Qg025843 for ; Sat, 10 May 2003 10:29:05 +1000 (EST) Original-Received: from localhost (ppp60.dyn228.pacific.net.au [203.143.228.60]) by wisma.pacific.net.au (8.12.9/8.12.9) with ESMTP id h4A0T4YZ019088 for ; Sat, 10 May 2003 10:29:04 +1000 (EST) Original-Received: from gg by localhost with local (Exim 3.35 #1 (Debian)) id 19EI8C-0004b2-00; Sat, 10 May 2003 10:22:28 +1000 Original-To: guile-devel@gnu.org In-Reply-To: <87wui76y0t.fsf@zip.com.au> (Kevin Ryde's message of "Mon, 07 Apr 2003 08:50:42 +1000") User-Agent: Gnus/5.090019 (Oort Gnus v0.19) Emacs/21.2 (gnu/linux) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Developers list for Guile, the GNU extensibility library List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.lisp.guile.devel:2312 X-Report-Spam: http://spam.gmane.org/gmane.lisp.guile.devel:2312 I wrote: > > A small one in (gcd n 0) I applied the changes I posted * numbers.c (scm_gcd): In bignum/inum, don't pass yy==0 to mpz_gcd_ui since we're only using the ulong return value, and x might not fit. * tests/numbers.test (gcd): Exercise bignum/inum with a bignum not fitting a ulong. _______________________________________________ Guile-devel mailing list Guile-devel@gnu.org http://mail.gnu.org/mailman/listinfo/guile-devel