From: Marius Vollmer <mvo@zagadka.de>
Cc: guile development <guile-devel@gnu.org>
Subject: Re: [PATCH] for strports.c: scm_c_eval_string_from_file_line
Date: 09 Jun 2003 21:53:56 +0200 [thread overview]
Message-ID: <87he6z9gdn.fsf@zagadka.ping.de> (raw)
In-Reply-To: <3EDA643E.2215A945@veritas.com>
Bruce Korb <bkorb@veritas.com> writes:
> Marius Vollmer wrote:
>
> > void
> > scm_c_primitive_load_from_string (const char *str,
> > const char *filename, int line)
> > {
> > SCM port, exp;
> >
> > port = scm_open_input_string (scm_str2string (str));
> > scm_set_port_file_name_x (port, scm_str2string (filename));
> > scm_set_port_line_x (port, scm_int2num (line));
> >
> > while (!SCM_EOF_OBJECT_P (exp = scm_read (port)))
> > scm_primitive_eval_x (exp);
> > }
> >
> > I think this quite straightforward, no?
>
> No.
Err, I mean, once you see how it is done. The manual can be improved,
I'm sure.
> [...] I also try to avoid gratuitous creations of
> string SCM's since the file name is generally invariant.
> You omitted returning the final value, which is important :-).
As you see, there are quite some variants on this theme, and I think
the above code is clean enough to allow for easy modification. There
is no black magic in it.
> It's easier to ignore if the caller doesn't want it. And, no,
> I didn't find that the research required to do this was obvious.
> In fact, there is no ``scm_set_port_file_name_x'' in 1.6.3, so
> you must be talking 1.7 here.
Oops, it is "scm_set_port_filename_x".
> I'm still working with 1.4. Therefore, I must directly assign to
> ``file_name''. I may as well assign the line number, too.
One more reason to join the happy Guile 1.6 club...
> I'd rather it was ready made so I can just #define my
> ``ag_scm_c_eval_string_from_file_line'' into
> ``scm_c_primitive_load_from_string''. You might tweak it a bit so a
> NULL file pointer bypasses the scm_set_port_file_name_x call. I'd
> also use "file_line" in the name, but that is your call.
Given these minor variations, I suggest you just use the function from
above. That way, you get exactly what you want.
--
GPG: D5D4E405 - 2F9B BCCC 8527 692A 04E3 331E FAF8 226A D5D4 E405
_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/guile-devel
prev parent reply other threads:[~2003-06-09 19:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-24 20:47 [PATCH] for strports.c: scm_c_eval_string_from_file_line Bruce Korb
2003-06-01 20:00 ` Marius Vollmer
2003-06-01 20:38 ` Bruce Korb
2003-06-09 19:53 ` Marius Vollmer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87he6z9gdn.fsf@zagadka.ping.de \
--to=mvo@zagadka.de \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).