slib system

slib system

[Kevin Ryde]

[-- Attachment #1: Type: text/plain, Size: 299 bytes --]

The core `system' returns a wait style exit status value, but slib
says system there should be a plain integer exit code like 0, 1, 2,
etc.

        * slib.scm (system): New function, giving an exit code return in
        accordance with slib spec.

This would be a bug fix for the 1.6 branch too.


[-- Attachment #2: slib.scm.system.diff --]
[-- Type: text/plain, Size: 811 bytes --]

--- slib.scm.~1.41.~	2004-01-04 07:14:41.000000000 +1000
+++ slib.scm	2004-01-07 09:52:19.000000000 +1000
@@ -246,6 +246,27 @@
 (define >?  >)
 (define >=? >=)
 
+;;; {system}
+;;;
+
+;; If the program run is killed by a signal, the shell normally gives an
+;; exit code of 128+signum.  If the shell itself is killed by a signal then
+;; we do the same 128+signum here.
+;;
+;; "stop-sig" shouldn't arise here, since system shouldn't be calling
+;; waitpid with WUNTRACED, but allow for it anyway, just in case.
+;;
+(if (defined? 'system)
+    (define-public system
+      (let ((core-system system))
+	(lambda (str)
+	  (let ((st (core-system str)))
+	    (cond ((status:exit-val st)
+		   => noop)
+		  (else
+		   (+ 128 (or (status:term-sig st)
+			      (status:stop-sig st))))))))))
+
 ;;; {Time}
 ;;;
 

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/guile-devel

Re: slib system

[Marius Vollmer]

Kevin Ryde <user42@zip.com.au> writes:

>         * slib.scm (system): New function, giving an exit code return in
>         accordance with slib spec.
>
> This would be a bug fix for the 1.6 branch too.

Yep.  (Short for: please apply.  Thanks!)

-- 
GPG: D5D4E405 - 2F9B BCCC 8527 692A 04E3  331E FAF8 226A D5D4 E405


_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/guile-devel