unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Kevin Ryde <user42@zip.com.au>
Subject: Re: [PATCH] Fix for `make-uniform-array'
Date: Fri, 03 Feb 2006 07:53:10 +1100	[thread overview]
Message-ID: <87hd7hqy89.fsf@zip.com.au> (raw)
In-Reply-To: <871wyn8otx.fsf@laas.fr> (Ludovic Courtès's message of "Wed, 01 Feb 2006 09:28:58 +0100")

ludovic.courtes@laas.fr (Ludovic Courtès) writes:
>
>   $ ./pre-inst-guile  # i.e., 1.7
>   guile> (define a (make-uniform-array #\nul 10))
>   ERROR: Wrong type (expecting exact integer): #\nul
>   ABORT: (wrong-type-arg)

That's a bug.  In 1.6 you could pass chars to array-set! (and fill)
with a #\nul (ie. byte) uniform array, that should still be possible.

(I thought I fixed something close to that another time too, before
the big srfi-4 integration.  Second time lucky maybe ...)

> -(define (make-uniform-array prot . args)
> -  (dimensions->uniform-array args prot))
> +(define (make-uniform-array prot . bounds)
> +  (dimensions->uniform-array bounds prot prot))

Thanks, I applied that.

But if you're fixing a bug then you should make a test case which
exercises the problem, to show it's really fixed (which I guess it's
not yet fully fixed in this case), and catch it if it rears its ugly
head again.


_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-devel


  reply	other threads:[~2006-02-02 20:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-01  8:28 [PATCH] Fix for `make-uniform-array' Ludovic Courtès
2006-02-02 20:53 ` Kevin Ryde [this message]
2006-02-12  1:08   ` Marius Vollmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hd7hqy89.fsf@zip.com.au \
    --to=user42@zip.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).