From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kevin Ryde Newsgroups: gmane.lisp.guile.devel Subject: Re: Improved (and faster) reader Date: Thu, 23 Aug 2007 11:08:07 +1000 Message-ID: <87hcmr83d4.fsf@zip.com.au> References: <1181845261.4156.1.camel@localhost.localdomain> <87zm1ojsie.fsf@chbouib.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: sea.gmane.org 1187831326 626 80.91.229.12 (23 Aug 2007 01:08:46 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 23 Aug 2007 01:08:46 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Thu Aug 23 03:08:43 2007 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IO1Bj-0000QZ-3m for guile-devel@m.gmane.org; Thu, 23 Aug 2007 03:08:43 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IO1Bi-0005Qj-KR for guile-devel@m.gmane.org; Wed, 22 Aug 2007 21:08:42 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IO1Be-0005NM-Sh for guile-devel@gnu.org; Wed, 22 Aug 2007 21:08:38 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IO1Bd-0005Mv-GR for guile-devel@gnu.org; Wed, 22 Aug 2007 21:08:38 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IO1Bd-0005Ms-A9 for guile-devel@gnu.org; Wed, 22 Aug 2007 21:08:37 -0400 Original-Received: from mailout1-1.pacific.net.au ([61.8.2.208] helo=mailout1.pacific.net.au) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IO1Bc-0005CU-Ny for guile-devel@gnu.org; Wed, 22 Aug 2007 21:08:37 -0400 Original-Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.2.163]) by mailout1.pacific.net.au (Postfix) with ESMTP id 0734B383E91 for ; Thu, 23 Aug 2007 11:08:35 +1000 (EST) Original-Received: from localhost (ppp2D55.dyn.pacific.net.au [61.8.45.85]) by mailproxy2.pacific.net.au (Postfix) with ESMTP id 7425627426 for ; Thu, 23 Aug 2007 11:08:32 +1000 (EST) Original-Received: from gg by localhost with local (Exim 4.67) (envelope-from ) id 1IO1B9-0001L0-Tx for guile-devel@gnu.org; Thu, 23 Aug 2007 11:08:07 +1000 In-Reply-To: <87zm1ojsie.fsf@chbouib.org> ("Ludovic =?iso-8859-1?Q?Court?= =?iso-8859-1?Q?=E8s=22's?= message of "Sun, 22 Jul 2007 18:46:33 +0200") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/22.1 (gnu/linux) X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:6738 Archived-At: --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable ludo@gnu.org (Ludovic Court=E8s) writes: > > +scm_read_quote (int chr, SCM port) I think you may have lost source properties from quote and quasi-quote forms, (read-enable 'positions) (source-properties (read (open-input-string "'x"))) =3D> () There wasn't a case in reader.test for that: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=reader.test.quote-positions.diff --- reader.test 16 Aug 2007 07:43:43 +1000 1.7.6.1 +++ reader.test 21 Aug 2007 18:11:04 +1000 @@ -152,5 +152,12 @@ (lambda () (read-string "(+ 1 2 3)"))))) (and (equal? (source-property sexp 'line) 0) + (equal? (source-property sexp 'column) 0)))) + + (pass-if "positions on quote" + (let ((sexp (with-read-options '(positions) + (lambda () + (read-string "'x"))))) + (and (equal? (source-property sexp 'line) 0) (equal? (source-property sexp 'column) 0))))) --=-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Guile-devel mailing list Guile-devel@gnu.org http://lists.gnu.org/mailman/listinfo/guile-devel --=-=-=--