Re: guile and visibility problems

Re: guile and visibility problems

[Ludovic Courtès]

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

Hi Patrick,

Sorry for the delay...

Patrick Horgan <phorgan1@gmail.com> writes:

> gcc (GCC) 4.3.1
> Linux dell 2.6.24-19-generic #1 SMP Wed Jun 18 14:43:41 UTC 2008 i686
> GNU/Linux

OK.  I had been using 4.2.3 until now, and I was able to reproduce the
problem with 4.3.1 (with 4.3, symbols not declared as `extern' are
considered as "common" symbols).

Can you try out the attached patch?  It seems to fix the problem for me.
To apply it:

  $ cd /path/to/guile
  $ patch -p1 < ,,no-common-symbols.diff

Thanks in advance,
Ludovic.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: The patch --]
[-- Type: text/x-patch, Size: 495 bytes --]

diff --git a/libguile/__scm.h b/libguile/__scm.h
index 76b4448..30077fd 100644
--- a/libguile/__scm.h
+++ b/libguile/__scm.h
@@ -101,9 +101,9 @@
  * as having "internal" linkage.  */
 #if (defined __GNUC__) && \
   ((__GNUC__ >= 4) || (__GNUC__ == 3 && __GNUC_MINOR__ == 3))
-# define SCM_INTERNAL  __attribute__ ((__visibility__ ("internal")))
+# define SCM_INTERNAL  extern __attribute__ ((__visibility__ ("internal")))
 #else
-# define SCM_INTERNAL
+# define SCM_INTERNAL  extern
 #endif
 
 

Re: guile and visibility problems

[Ludovic Courtès]

Hi,

All this is now fixed in Git.

Thanks!

Ludovic.