From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: [Guile-commits] GNU Guile branch, master, updated. release_1-9-1-17-g77332b2 Date: Fri, 31 Jul 2009 00:57:20 +0200 Message-ID: <87hbwtaien.fsf@gnu.org> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1248994662 24006 80.91.229.12 (30 Jul 2009 22:57:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 30 Jul 2009 22:57:42 +0000 (UTC) Cc: guile-devel@gnu.org To: "Michael Gran" Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Fri Jul 31 00:57:35 2009 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MWeZ5-0004L3-47 for guile-devel@m.gmane.org; Fri, 31 Jul 2009 00:57:35 +0200 Original-Received: from localhost ([127.0.0.1]:50300 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWeZ4-0000eM-Ad for guile-devel@m.gmane.org; Thu, 30 Jul 2009 18:57:34 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MWeZ1-0000eH-ED for guile-devel@gnu.org; Thu, 30 Jul 2009 18:57:31 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MWeYw-0000e5-0P for guile-devel@gnu.org; Thu, 30 Jul 2009 18:57:30 -0400 Original-Received: from [199.232.76.173] (port=51181 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWeYv-0000e2-RH for guile-devel@gnu.org; Thu, 30 Jul 2009 18:57:25 -0400 Original-Received: from mail1-relais-roc.national.inria.fr ([192.134.164.82]:28357) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MWeYv-0003rf-9Y for guile-devel@gnu.org; Thu, 30 Jul 2009 18:57:25 -0400 X-IronPort-AV: E=Sophos;i="4.43,297,1246831200"; d="scan'208";a="33854047" Original-Received: from reverse-83.fdn.fr (HELO nixey) ([80.67.176.83]) by mail1-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES128-SHA; 31 Jul 2009 00:57:23 +0200 X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 13 Thermidor an 217 de la =?iso-8859-1?Q?R=E9volutio?= =?iso-8859-1?Q?n?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 821D 815D 902A 7EAB 5CEE D120 7FBA 3D4F EB1F 5364 X-OS: x86_64-unknown-linux-gnu In-Reply-To: (Michael Gran's message of "Tue, 28 Jul 2009 04:04:25 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:8994 Archived-At: Hello! "Michael Gran" writes: > The branch, master has been updated > via 77332b21a01fac906ae4707426e00f01e62c0415 (commit) > from e5dc27b86d0eaa470f92cdaa9f4ed2a961338c49 (commit) Oops, I hadn't realized this was in `master'. Was it intended? (I don't remember seeing a discussion, but I may have skipped it.) > Replace global charnames variables with accessors > > The global variables scm_charnames and scm_charnums are replaced with > the accessor functions scm_i_charname and scm_i_charname_to_num. > Also, the incomplete and broken EBCDIC support is removed. Does it have a user-visible effect? (If so, please update `NEWS' for 1.9.1->1.9.2.) > * libguile/print.c (iprin1): use new func scm_i_charname > > * libguile/read.c (scm_read_character): use new func > scm_i_charname_to_num > > * libguile/chars.c (scm_i_charname): new function > (scm_i_charname_to_char): new function > (scm_charnames, scm_charnums): removed These removals are incompatible in theory, but probably they don't warrant a `NEWS' entry. Thoughts? > +const char *const scm_r5rs_charnames[] = Please follow the GCS when it comes to spacing, indentation, etc. If in doubt, run GNU Indent. > +int scm_n_C0_control_charnames = sizeof (scm_C0_control_charnames) / sizeof (char *); Scary name! ;-) Shouldn't it be private? And shouldn't it be a macro instead? Thanks, Ludo'.