unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: guile-devel@gnu.org
Subject: Re: bdw-gc includes in libguile.h
Date: Fri, 25 Mar 2011 19:06:55 +0100	[thread overview]
Message-ID: <87hbardqgw.fsf@gnu.org> (raw)
In-Reply-To: m3tyerh755.fsf@unquote.localdomain

Hello,

Andy Wingo <wingo@pobox.com> writes:

> I think we made a mistake in exposing bdw-gc.h to libguile.h users.
> gc.h is quite scrupulous to not include it, but smob.h, inline.h
> (sometimes), and pthread-threads.h pull it in.

<libguile/bdw-gc.h> is intentionally pulled because our public headers
use macros and inlines from <gc/gc.h>.

> Besides the modularity concerns that lead us to need to add bdw-gc libs
> and cflags to Guile's libs and cflags, there is an acute problem, and
> that is that we enable pthread redirects -- so users of libguile get
> pthread_create et al re-#defined.

Yes, that’s intended.

> I think that in 2.2 we should not expose libgc interfaces in libguile,

That would be great, but then ‘scm_cell’, ‘SCM_NEWSMOB’, etc. would
need to do a function call, which we don’t want.  Even if we did want
it, the change would break the ABI.

> and that in 2.0 we should disable pthread redirects.

Why?

We rely on pthread redirects internally and if users use pthread, then
they need it too, I suppose.

A meta-comment: can we agree to take more time to discuss this sort of
things?  I’ll try to be responsive, and the earth won’t stop spinning if
the fix waits a couple of days.  ;-)

Thanks,
Ludo’.




  parent reply	other threads:[~2011-03-25 18:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-25  9:38 bdw-gc includes in libguile.h Andy Wingo
2011-03-25 16:44 ` Andy Wingo
2011-03-25 18:06 ` Ludovic Courtès [this message]
2011-03-25 18:44   ` Andy Wingo
2011-03-27 15:11     ` Ludovic Courtès
2011-03-28  7:35       ` Andy Wingo
2011-03-28 19:22         ` Ludovic Courtès
2011-03-28 19:41           ` Andy Wingo
2011-03-28 20:40             ` Ludovic Courtès
2011-03-29  9:16               ` Andy Wingo
2011-03-30 16:15                 ` Ludovic Courtès
2011-03-30 16:23                   ` Andy Wingo
2011-05-26 16:48     ` Andy Wingo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hbardqgw.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guile-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).