From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: build-lexical-var vs. -Wunused-variable Date: Thu, 01 Mar 2012 19:26:03 +0100 Message-ID: <87hay89o04.fsf@gnu.org> References: <87ty2p4tct.fsf@gnu.org> <87d39a1qgl.fsf@pobox.com> <87k43ez0ey.fsf@netris.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1330626383 23878 80.91.229.3 (1 Mar 2012 18:26:23 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 1 Mar 2012 18:26:23 +0000 (UTC) Cc: Andy Wingo , guile-devel@gnu.org To: Mark H Weaver Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Thu Mar 01 19:26:22 2012 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1S3Ahp-0005sZ-UZ for guile-devel@m.gmane.org; Thu, 01 Mar 2012 19:26:22 +0100 Original-Received: from localhost ([::1]:33116 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S3Ahp-0007ks-BD for guile-devel@m.gmane.org; Thu, 01 Mar 2012 13:26:21 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:32922) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S3Ahh-0007kM-B7 for guile-devel@gnu.org; Thu, 01 Mar 2012 13:26:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S3Ahb-0006Xf-By for guile-devel@gnu.org; Thu, 01 Mar 2012 13:26:12 -0500 Original-Received: from xanadu.aquilenet.fr ([88.191.123.111]:46708) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S3Ahb-0006XK-5i for guile-devel@gnu.org; Thu, 01 Mar 2012 13:26:07 -0500 Original-Received: from localhost (xanadu.aquilenet.fr [127.0.0.1]) by xanadu.aquilenet.fr (Postfix) with ESMTP id 8E86A7022; Thu, 1 Mar 2012 19:26:05 +0100 (CET) Original-Received: from xanadu.aquilenet.fr ([127.0.0.1]) by localhost (xanadu.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7QbjJ4rDhN3T; Thu, 1 Mar 2012 19:26:05 +0100 (CET) Original-Received: from pluto (reverse-83.fdn.fr [80.67.176.83]) by xanadu.aquilenet.fr (Postfix) with ESMTPSA id BA70C7003; Thu, 1 Mar 2012 19:26:04 +0100 (CET) X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 12 =?iso-8859-1?Q?Vent=F4se?= an 220 de la =?iso-8859-1?Q?R=E9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu In-Reply-To: <87k43ez0ey.fsf@netris.org> (Mark H. Weaver's message of "Wed, 22 Feb 2012 22:36:05 -0500") User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.93 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 88.191.123.111 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:13966 Archived-At: Hello! Mark H Weaver skribis: > Andy Wingo writes: >> On Fri 17 Feb 2012 12:00, ludo@gnu.org (Ludovic Court=C3=A8s) writes: >> >>> Commit f9685f437312ea790981373ddc375b2a26ba9c4f changes >>> =E2=80=98build-lexical-var=E2=80=99 like this: >>> >>> (define-syntax-rule (build-lexical-var src id) >>> - (gensym (string-append (symbol->string id) " "))) >>> + (gensym (string-append (symbol->string id) "-"))) >>> >>> This breaks a heuristic used in the =E2=80=98unused-variable=E2=80=99 p= ass, which is >>> that identifiers containing white space are likely introduced by a macro >>> and can be ignored in unused-variable reports (see =E2=80=98gensym?=E2= =80=99 in >>> =E2=80=98tree-il/analyze.scm=E2=80=99). >>> >>> OK to change it back? >> >> How about we use `$' instead? I understand that's how Chez does it. >> I'd really rather something that is printable without the #{#} syntax. > > Now that we have a (pending) patch to avoid printing gensyms to > psyntax-pp.scm, does that change your opinion on this? I tend to agree > with Ludovic here. In general, any character that doesn't require the > #{}# syntax is likely to be used by some programs in their identifier > names. It would be a shame if we disabled unused-variable warnings for > variables whose name contains a '$', or any other standard identifier > character for that matter. Any news on this? I=E2=80=99d agree with Mark, but no strong opinion here. Thanks, Ludo=E2=80=99.