From: BT Templeton <bpt@hcoop.net>
To: guile-devel@gnu.org
Subject: [PATCH] primitive resolution for public refs
Date: Mon, 12 Mar 2012 12:42:32 -0400 [thread overview]
Message-ID: <87haxt3h53.fsf@olor.terpri.org> (raw)
* module/language/tree-il/primitives.scm (resolve-primitives!): Resolve
public module-refs to primitives.
---
module/language/tree-il/primitives.scm | 16 +++++++++-------
1 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/module/language/tree-il/primitives.scm b/module/language/tree-il/primitives.scm
index 3c6769d..1dcab20 100644
--- a/module/language/tree-il/primitives.scm
+++ b/module/language/tree-il/primitives.scm
@@ -265,13 +265,15 @@
(module-variable mod name)))
(lambda (name) (make-primitive-ref src name))))
((<module-ref> src mod name public?)
- ;; for the moment, we're disabling primitive resolution for
- ;; public refs because resolve-interface can raise errors.
- (let ((m (and (not public?) (resolve-module mod))))
- (and m
- (and=> (hashq-ref *interesting-primitive-vars*
- (module-variable m name))
- (lambda (name) (make-primitive-ref src name))))))
+ (and=> (and=> (resolve-module mod)
+ (if public?
+ module-public-interface
+ identity))
+ (lambda (m)
+ (and=> (hashq-ref *interesting-primitive-vars*
+ (module-variable m name))
+ (lambda (name)
+ (make-primitive-ref src name))))))
((<call> src proc args)
(and (primitive-ref? proc)
(make-primcall src (primitive-ref-name proc) args)))
--
1.7.9.1
next reply other threads:[~2012-03-12 16:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 16:42 BT Templeton [this message]
2012-03-12 17:17 ` [PATCH] primitive resolution for public refs Noah Lavine
2012-03-12 18:03 ` BT Templeton
2012-03-12 19:42 ` Noah Lavine
2012-03-12 21:05 ` BT Templeton
2012-03-16 11:22 ` Ludovic Courtès
2012-03-16 19:38 ` BT Templeton
2012-03-21 21:58 ` Ludovic Courtès
2012-04-09 21:16 ` BT Templeton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87haxt3h53.fsf@olor.terpri.org \
--to=bpt@hcoop.net \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).