From: Andy Wingo <wingo@pobox.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: guile-devel@gnu.org
Subject: Re: Avoid warning about alloca in read.c
Date: Sat, 23 Jul 2016 22:57:02 +0200 [thread overview]
Message-ID: <87h9bgrs2p.fsf@pobox.com> (raw)
In-Reply-To: <831t2t5wnx.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 16 Jul 2016 20:18:26 +0300")
On Sat 16 Jul 2016 19:18, Eli Zaretskii <eliz@gnu.org> writes:
> CC libguile_2.0_la-read.lo
> read.c: In function 'try_read_ci_chars':
> read.c:983:3: warning: implicit declaration of function 'alloca' [-Wimplicit-function-declaration]
> read.c:983:22: warning: incompatible implicit declaration of built-in function 'alloca' [enabled by default]
>
> The patch to avoid this warning is below. OK to commit?
>
> --- libguile/read.c~0 2016-01-02 16:24:55.000000000 +0200
> +++ libguile/read.c 2016-07-15 12:38:42.195125000 +0300
> @@ -33,6 +33,10 @@
> #include <c-strcase.h>
> #include <c-ctype.h>
>
> +#ifdef __MINGW32__
> +#include <alloca.h>
> +#endif
> +
OK to commit but please remove the ifdef -- just include <alloca.h> in all
cases.
Thanks!
Andy
next prev parent reply other threads:[~2016-07-23 20:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-16 17:18 Avoid warning about alloca in read.c Eli Zaretskii
2016-07-22 7:17 ` Eli Zaretskii
2016-07-23 20:57 ` Andy Wingo [this message]
2016-07-24 2:39 ` Eli Zaretskii
2016-07-24 13:35 ` Andy Wingo
2016-07-24 15:15 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9bgrs2p.fsf@pobox.com \
--to=wingo@pobox.com \
--cc=eliz@gnu.org \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).