From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Add to the 2.1.x branch GUILE_SITE_CCACHE_DIR and GUILE_EXTENSION_DIR Autoconf macros along with needed siteccachdir entry in pkgconfig file Date: Tue, 14 Mar 2017 15:53:00 +0100 Message-ID: <87h92v7vw3.fsf@pobox.com> References: <878to9s5s9.fsf@pobox.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1489503208 21708 195.159.176.226 (14 Mar 2017 14:53:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 14 Mar 2017 14:53:28 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: guile-devel@gnu.org To: Freja Nordsiek Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Tue Mar 14 15:53:20 2017 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnnp9-0004eT-3P for guile-devel@m.gmane.org; Tue, 14 Mar 2017 15:53:19 +0100 Original-Received: from localhost ([::1]:59934 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnnpE-0007A9-V3 for guile-devel@m.gmane.org; Tue, 14 Mar 2017 10:53:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58164) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnnp2-00078l-I3 for guile-devel@gnu.org; Tue, 14 Mar 2017 10:53:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cnnoz-0003hc-GP for guile-devel@gnu.org; Tue, 14 Mar 2017 10:53:12 -0400 Original-Received: from pb-sasl1.pobox.com ([64.147.108.66]:61765 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cnnoz-0003h7-Bj for guile-devel@gnu.org; Tue, 14 Mar 2017 10:53:09 -0400 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-sasl1.pobox.com (Postfix) with ESMTP id DC27C69BCD; Tue, 14 Mar 2017 10:53:08 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=xuLYF1CBDsWSYJiIm3QvXBiDSJM=; b=U/BPhh nl6RpWVfUFg33Jy1A93lN0yMid45GfRdJYzxkM55Gb3h3wmBEF7VFdmpQvZaZwFr qN83iCcaDowrX7EmWRqUyaUaqmtlQllU+h08BNj/EVSu+zAJmbLEke6YOc54iRRI eGEEVDzeqgPqcErtdUpGMTn8yMms4IM4CyQ9Y= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=BVFjM8cBBh3G3ixS7uJFn7tXnaSqcjhZ gv91m14Lld+aswvC0sfkbEoy/BZbkI8QGzLhuy+B3lsVlB9J1JYre2CCEuMxVrwy 76ShA2W+5vBsfn629jGRJvIrxV9k0b5dqWwtdWxm57f3n2lS5ZsnhCuf+FwfzM8z yTcFsGC9gY4= Original-Received: from pb-sasl1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-sasl1.pobox.com (Postfix) with ESMTP id D5B5B69BCC; Tue, 14 Mar 2017 10:53:08 -0400 (EDT) Original-Received: from clucks (unknown [88.160.190.192]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-sasl1.pobox.com (Postfix) with ESMTPSA id C2C9869BC7; Tue, 14 Mar 2017 10:53:07 -0400 (EDT) In-Reply-To: (Freja Nordsiek's message of "Tue, 14 Mar 2017 15:08:47 +0100") X-Pobox-Relay-ID: EFADABD2-08C5-11E7-8E3C-B667064AB293-02397024!pb-sasl1.pobox.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 64.147.108.66 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.org gmane.lisp.guile.devel:19044 Archived-At: Hi :) Great patch, some comments. On Tue 14 Mar 2017 15:08, Freja Nordsiek writes: > From 90daf796c829f8e422a281d501f711138f21a334 Mon Sep 17 00:00:00 2001 > From: Freja Nordsiek > Date: Tue, 14 Mar 2017 15:04:38 +0100 > Subject: [PATCH] Made GUILE_SITE_DIR Autoconf macro look for directories for > compiled .go and C extensions in addition to the site directory for scheme > files. Please adapt the commit log. (Just look at any other commit to see what the standard is.) You might also be interested in "info standards". > -## GUILE_SITE_DIR -- find path to Guile "site" directory > +## GUILE_SITE_DIR -- find path to Guile "site" directories for scheme, compiles GO files, and compiled C extensions Line too long. Probably just s/directories.*/directories./. > -# GUILE_SITE_DIR -- find path to Guile "site" directory > +# GUILE_SITE_DIR -- find path to Guile site directories > -# This looks for Guile's "site" directory, usually something like > -# PREFIX/share/guile/site, and sets var @var{GUILE_SITE} to the path. > -# Note that the var name is different from the macro name. > +# This looks for Guile's "site" directory for Scheme files (usually something like > +# PREFIX/share/guile/site), "site-ccache" directory for compiled @code{.go} files > +# (usually something like PREFIX/lib/guile/@var{GUILE_EFFECTIVE_VERSION}/site-ccache), > +# and "extensions" directory for compiled C extensions (usually something like > +# PREFIX/lib/guile/@var{GUILE_EFFECTIVE_VERSION}/extensions). The variables > +# @var{GUILE_SITE}, @var{GUILE_SITE_CCACHE}, and @var{GUILE_EXTENSION} are set to these > +# paths respectively. The latter two are set to blank if they are not found. Note that > +# this macro will run the macros @code{GUILE_PKG} and @code{GUILE_PROGS} if they have > +# not already been run. Can we make the text more terse? E.g. 'This looks for Guile's "site" directories. The variable @var{GUILE_SITE} will be set to Guile's "site" directory for Scheme source files (usually [...]). @var{GUILE_SITE_CCACHE} will be set to the directory for compiled Scheme files (usually [...])' and so on. Two spaces before periods please in comments in Guile code. > -# The variable is marked for substitution, as by @code{AC_SUBST}. > +# The variables are marked for substitution, as by @code{AC_SUBST}. > # > AC_DEFUN([GUILE_SITE_DIR], > [AC_REQUIRE([GUILE_PKG]) > + AC_REQUIRE([GUILE_PROGS]) I guess this is OK given that anyone installing Scheme files should install .go files, and you need GUILE_PROGS to build .go files. > + AC_MSG_CHECKING([for Guile site-ccache directory]) > + GUILE_SITE_CCACHE=`$GUILE -c "(display (if (defined? '%site-ccache-dir) (%site-ccache-dir) \"\"))"` You prefer this rather than first trying pkg-config? I would try pkg-config first; but it doesn't really matter I guess :) Otherwise looking fine. Thanks! Andy