From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Mark H Weaver Newsgroups: gmane.lisp.guile.devel Subject: Re: Unexpectedly low read/write performance of open-pipe Date: Tue, 09 Apr 2019 14:33:27 -0400 Message-ID: <87h8b7rpt9.fsf@netris.org> References: <87d0lxmzyv.fsf@trouble.defaultvalue.org> <878swlmz6q.fsf@trouble.defaultvalue.org> <874l79mwbw.fsf@trouble.defaultvalue.org> <87zhp1ld31.fsf@trouble.defaultvalue.org> <87sgus6a65.fsf@netris.org> <87k1g3ll96.fsf@trouble.defaultvalue.org> <87k1g3y3re.fsf@netris.org> <20190409102140.f4d9d1e7c6457c23eea29964@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="200960"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: guile-devel@gnu.org To: Chris Vine Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Tue Apr 09 20:35:09 2019 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDvaO-000qAd-4J for guile-devel@m.gmane.org; Tue, 09 Apr 2019 20:35:08 +0200 Original-Received: from localhost ([127.0.0.1]:47528 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDvaM-0001Nh-SX for guile-devel@m.gmane.org; Tue, 09 Apr 2019 14:35:06 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDvaI-0001My-3U for guile-devel@gnu.org; Tue, 09 Apr 2019 14:35:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDvaH-0006jb-8m for guile-devel@gnu.org; Tue, 09 Apr 2019 14:35:02 -0400 Original-Received: from world.peace.net ([64.112.178.59]:33050) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hDvaH-0006gx-1o for guile-devel@gnu.org; Tue, 09 Apr 2019 14:35:01 -0400 Original-Received: from mhw by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hDvaF-000778-Os; Tue, 09 Apr 2019 14:34:59 -0400 In-Reply-To: <20190409102140.f4d9d1e7c6457c23eea29964@gmail.com> (Chris Vine's message of "Tue, 9 Apr 2019 10:21:40 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 64.112.178.59 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.org gmane.lisp.guile.devel:19884 Archived-At: Chris Vine writes: > On Tue, 09 Apr 2019 04:35:38 -0400 > Mark H Weaver wrote: >> >> I think it's probably fine for 2.2, although a more careful check should >> be made for differences in behavior between the old and new >> implementations, and tests should be added. I'll try to get to it soon. > > If it is going in 2.2 (or 3.0) it would be nice if the ports could be > suspendable. put-bytevector (used by write!) is suspendable; > get-bytevector-some (used by read!) is not. In my previous message, I forgot to mention that I don't believe my patch would introduce a regression here, because the old implementation of 'open-pipe*' in OPEN_BOTH mode _also_ used a kind of custom port implemented in C, namely Guile's old "soft ports". That said, I certainly agree that it would be good to make more I/O operations suspendable, and to make custom ports suspendable as well. Mark