unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: "Dr. Arne Babenhauserheide" <arne_bab@web.de>
To: Josselin Poiret <dev@jpoiret.xyz>
Cc: Dmitry Alexandrov <dag@gnui.org>,
	Matt Wette <matt.wette@gmail.com>,
	guile-devel@gnu.org
Subject: Re: pull requests for guile
Date: Mon, 08 May 2023 23:03:05 +0200	[thread overview]
Message-ID: <87h6smpltt.fsf@web.de> (raw)
In-Reply-To: <87fs866b5v.fsf@jpoiret.xyz>

[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]


Josselin Poiret <dev@jpoiret.xyz> writes:

> Reciprocally, I don't think a simple pull request provides much over
> git-am, except that with `format-patch`, everything is simply text, that
> once sent over email (in a decentralized fashion) can be simply
> responded to and read without relying on complicated javascript in a
> browser, and using your mail reader of choice.

I think that this is the biggest advantage of patches by email:
discussing patches via email is more accessible for people with an
existing setup.

Reworking patches iteratively is harder (no simple folding and unfolding
of applied requests, no automatic current diff, no short list of commit
summaries), and accepting patches without changes is harder without
extra setup (no single click on a button), getting an accessible list of
existing submissions takes more knowledge, but the discussion itself is
easier.

With thunderbird such a review would have been somewhat OK, maybe a bit
annoying, but since I switched to reading email with Emacs, reading
patches by email is at least as easy as with a pull-request — and it’s a
system that works on any platform. And I don’t even have much tooling
for that. If I merged many patches, I’d write a small convenience
function to apply the selected region as patch to Guile.

Best wishes,
Arne
-- 
Unpolitisch sein
heißt politisch sein,
ohne es zu merken.
draketo.de

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 1125 bytes --]

  reply	other threads:[~2023-05-08 21:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-06 16:21 pull requests for guile Matt Wette
2023-05-08 11:32 ` Dmitry Alexandrov
2023-05-08 16:27   ` Josselin Poiret
2023-05-08 21:03     ` Dr. Arne Babenhauserheide [this message]
2023-05-08 17:03 ` Arsen Arsenović

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6smpltt.fsf@web.de \
    --to=arne_bab@web.de \
    --cc=dag@gnui.org \
    --cc=dev@jpoiret.xyz \
    --cc=guile-devel@gnu.org \
    --cc=matt.wette@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).