From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludovic.courtes@laas.fr (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Turning `scm_is_pair ()' into a macro Date: Thu, 15 Dec 2005 10:39:59 +0100 Organization: LAAS-CNRS Message-ID: <87fyouitqo.fsf@laas.fr> References: <87wti7pwie.fsf@laas.fr> <87ek4ftgge.fsf@zagadka.de> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1134651329 2616 80.91.229.2 (15 Dec 2005 12:55:29 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 15 Dec 2005 12:55:29 +0000 (UTC) Cc: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Thu Dec 15 13:55:18 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EmscB-0001cq-Qm for guile-devel@m.gmane.org; Thu, 15 Dec 2005 13:53:44 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Emscp-0000SZ-5S for guile-devel@m.gmane.org; Thu, 15 Dec 2005 07:54:23 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EmpgM-00022D-UU for guile-devel@gnu.org; Thu, 15 Dec 2005 04:45:51 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EmpgJ-000213-La for guile-devel@gnu.org; Thu, 15 Dec 2005 04:45:48 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Empbv-0001d0-1e for guile-devel@gnu.org; Thu, 15 Dec 2005 04:41:17 -0500 Original-Received: from [140.93.0.15] (helo=laas.laas.fr) by monty-python.gnu.org with esmtp (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.34) id 1Empe8-0004vn-IY for guile-devel@gnu.org; Thu, 15 Dec 2005 04:43:32 -0500 Original-Received: by laas.laas.fr (8.13.1/8.13.4) with SMTP id jBF9eSVb027233; Thu, 15 Dec 2005 10:40:32 +0100 (CET) Original-To: Marius Vollmer X-URL: http://www.laas.fr/~lcourtes/ X-Revolutionary-Date: 25 Frimaire an 214 de la =?iso-8859-1?Q?R=E9volution?= X-PGP-Key-ID: 0xEB1F5364 X-PGP-Key: http://www.laas.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 821D 815D 902A 7EAB 5CEE D120 7FBA 3D4F EB1F 5364 X-OS: powerpc-unknown-linux-gnu Mail-Followup-To: Marius Vollmer , guile-devel@gnu.org In-Reply-To: <87ek4ftgge.fsf@zagadka.de> (Marius Vollmer's message of "Thu, 15 Dec 2005 01:19:13 +0200") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux) X-Spam-Score: 0 () X-Scanned-By: MIMEDefang at CNRS-LAAS X-MIME-Autoconverted: from 8bit to quoted-printable by laas.laas.fr id jBF9eSVb027233 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:5524 Archived-At: Hi, Marius Vollmer writes: > Yep. But what about an inline function? There is some machinery in > inline.h for this and we already use it for scm_cell, for example. I'm all in favor of inline functions. But since we want to support compilers that don't support inlining, we have to use the whole machinery that's in `inline.h'. That machinery is only used in `inline.h', while we would like `scm_is_pair ()' to be defined in `pairs.h'. IOW, making the inlining machinery easily usable is not that easy, and, well, I'm lazy too. ;-) Do you have a suggestion for this? Since `scm_is_pair ()' was already in 1.7.2, maybe it'd make sense to keep a non-inlined version of it. Maybe not (e.g., if we are to change library version numbers). BTW, below is a related fix that I forgot to post earlier. Thanks, Ludovic. 2005-12-15 Ludovic Court=E8s * socket.c: Include "libguile/pairs.h". --- orig/libguile/socket.c +++ mod/libguile/socket.c @@ -35,6 +35,7 @@ =20 #include "libguile/validate.h" #include "libguile/socket.h" +#include "libguile/pairs.h" =20 #ifdef __MINGW32__ #include "win32-socket.h" _______________________________________________ Guile-devel mailing list Guile-devel@gnu.org http://lists.gnu.org/mailman/listinfo/guile-devel