From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: [Guile-commits] GNU Guile branch, master, updated. release_1-9-2-164-g0d05ae7 Date: Wed, 09 Sep 2009 01:00:47 +0200 Message-ID: <87fxaxavog.fsf@gnu.org> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1252450878 4578 80.91.229.12 (8 Sep 2009 23:01:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 8 Sep 2009 23:01:18 +0000 (UTC) Cc: guile-devel@gnu.org To: "Michael Gran" Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Sep 09 01:01:11 2009 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Ml9gP-0005sQ-1i for guile-devel@m.gmane.org; Wed, 09 Sep 2009 01:01:05 +0200 Original-Received: from localhost ([127.0.0.1]:60635 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ml9gO-00011c-Fp for guile-devel@m.gmane.org; Tue, 08 Sep 2009 19:01:04 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ml9gI-00011N-6E for guile-devel@gnu.org; Tue, 08 Sep 2009 19:00:58 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ml9gC-000118-RE for guile-devel@gnu.org; Tue, 08 Sep 2009 19:00:56 -0400 Original-Received: from [199.232.76.173] (port=57001 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ml9gC-000115-KU for guile-devel@gnu.org; Tue, 08 Sep 2009 19:00:52 -0400 Original-Received: from mail4-relais-sop.national.inria.fr ([192.134.164.105]:60596) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1Ml9gB-0001eR-SL for guile-devel@gnu.org; Tue, 08 Sep 2009 19:00:52 -0400 X-IronPort-AV: E=Sophos;i="4.44,354,1249250400"; d="scan'208";a="46218769" Original-Received: from unknown (HELO nixey) ([78.251.30.115]) by mail4-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES128-SHA; 09 Sep 2009 01:00:50 +0200 X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 23 Fructidor an 217 de la =?iso-8859-1?Q?R=E9volutio?= =?iso-8859-1?Q?n?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 821D 815D 902A 7EAB 5CEE D120 7FBA 3D4F EB1F 5364 X-OS: x86_64-unknown-linux-gnu In-Reply-To: (Michael Gran's message of "Tue, 08 Sep 2009 02:13:41 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:9279 Archived-At: Hello! "Michael Gran" writes: > http://git.savannah.gnu.org/cgit/guile.git/commit/?id=3D0d05ae7c4b1eddf62= 57f99f44eaf5cb7b11191be [...] > - return scm_getc (input_port); > + return scm_get_byte_or_eof (input_port); This is actually an earlier change, but the prototype of scm_getc is now different from that in 1.8. Presumably, this means that it=E2=80=99s not source-compatible with 1.8, e.g., on platforms where sizeof=C2=A0(int)=C2=A0<=C2=A0sizeof=C2=A0(scm_t_wchar), right? > --- a/libguile/strings.h > +++ b/libguile/strings.h > @@ -111,7 +111,7 @@ SCM_API SCM scm_substring_shared (SCM str, SCM start,= SCM end); > SCM_API SCM scm_substring_copy (SCM str, SCM start, SCM end); > SCM_API SCM scm_string_append (SCM args); >=20=20 > -SCM_INTERNAL SCM scm_i_from_stringn (const char *str, size_t len,=20 > +SCM_API SCM scm_i_from_stringn (const char *str, size_t len,=20 > const char *encoding, > scm_t_string_failed_conversion_hand= ler=20 > handler); > @@ -157,7 +157,7 @@ SCM_INTERNAL const scm_t_wchar *scm_i_string_wide_cha= rs (SCM str); > SCM_INTERNAL SCM scm_i_string_start_writing (SCM str); > SCM_INTERNAL void scm_i_string_stop_writing (void); > SCM_INTERNAL int scm_i_is_narrow_string (SCM str); > -SCM_INTERNAL scm_t_wchar scm_i_string_ref (SCM str, size_t x); > +SCM_API scm_t_wchar scm_i_string_ref (SCM str, size_t x); Were these changes intended? > + (with-locale "en_US.iso88591" > + (pass-if-exception "no args" exception:wrong-num-args > + (regexp-quote)) Is the locale part of the API? That is, should programs that use regexps explicitly ask for a locale with 8-bit encoding? Thanks, Ludo=E2=80=99.