From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Add internal-only port structure; move iconv descriptors there Date: Mon, 01 Apr 2013 20:57:00 +0200 Message-ID: <87fvzadqpv.fsf@pobox.com> References: <87vc9ij5z0.fsf@pobox.com> <87fw0l2yyk.fsf@gnu.org> <877gltxgrg.fsf_-_@tines.lan> <87y5e8stst.fsf@pobox.com> <87d2vdekws.fsf@tines.lan> <87d2uk62a0.fsf_-_@tines.lan> <87a9poin2d.fsf@pobox.com> <87zjxk57l6.fsf_-_@tines.lan> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1364842721 16322 80.91.229.3 (1 Apr 2013 18:58:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 1 Apr 2013 18:58:41 +0000 (UTC) Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , guile-devel@gnu.org To: Mark H Weaver Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Mon Apr 01 20:59:08 2013 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UMjwf-0002mi-IO for guile-devel@m.gmane.org; Mon, 01 Apr 2013 20:59:05 +0200 Original-Received: from localhost ([::1]:53465 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMjwH-00020f-3g for guile-devel@m.gmane.org; Mon, 01 Apr 2013 14:58:41 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:49911) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMjwB-00020K-LZ for guile-devel@gnu.org; Mon, 01 Apr 2013 14:58:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UMjw9-0008Bn-Tn for guile-devel@gnu.org; Mon, 01 Apr 2013 14:58:35 -0400 Original-Received: from a-pb-sasl-quonix.pobox.com ([208.72.237.25]:51585 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMjw9-0007gp-Q3; Mon, 01 Apr 2013 14:58:33 -0400 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id 2FF63B33D; Mon, 1 Apr 2013 14:57:03 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=S+clAZ+r4R4qI2xwBL3sauEUFq8=; b=ULvcgL SURlJ+BgUt57/f9EeXSk4MDg2DElQJ2+pkoqFIhV86aUp6d69ZEulvsOe+1kknC1 4iKceEBj/wopBcMfI8wI2eIAKai/m7jDV1DDda842YJZirIRlMtC6BsiI9FPFh5/ qWqnRK4TcG6KizyGA/JqJ1JKx8evgL8atD3CI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=IF+qe1a0vIiHunAtZEUHJNO6vatEgXAU GT5NufT2bJra+nqjUlOS4R7LvttOBnfyx7fjHDQJSyd+07znWhfwSMw8XntXjMvQ 1NTRKZF65IyDnaH+WoK5fpijOc/AovgUyDHKD7F6JE+ATrAO65f0qoFGV56A/en9 gxIG0Gs+y3A= Original-Received: from a-pb-sasl-quonix.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id 26C09B33C; Mon, 1 Apr 2013 14:57:03 -0400 (EDT) Original-Received: from badger (unknown [88.160.190.192]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTPSA id 9D5B3B33A; Mon, 1 Apr 2013 14:57:02 -0400 (EDT) In-Reply-To: <87zjxk57l6.fsf_-_@tines.lan> (Mark H. Weaver's message of "Sun, 31 Mar 2013 03:52:53 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) X-Pobox-Relay-ID: F08D9C4A-9AFD-11E2-A42E-D36F0E5B5709-02397024!a-pb-sasl-quonix.pobox.com X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 208.72.237.25 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:16094 Archived-At: LGTM if these are addressed: On Sun 31 Mar 2013 09:52, Mark H Weaver writes: > +#define SCM_INTERNAL_PTAB_ENTRY(x) \ > + ((scm_t_port_internal *) (SCM_PTAB_ENTRY(x)->input_cd)) > + SCM_PORT_GET_INTERNAL(x) ? PTAB is a historical name (port table; there is no more port table.) > SCM z = scm_cons (SCM_EOL, SCM_EOL); > - scm_t_port *entry = (scm_t_port *) scm_gc_calloc (sizeof (scm_t_port), "port"); > + scm_t_port *entry = scm_gc_typed_calloc (scm_t_port); > + scm_t_port_internal *pti = scm_gc_typed_calloc (scm_t_port_internal); > const char *enc; How about allocating a struct { scm_t_port a; scm_t_port_internal b; } and get the pointers from there? Andy -- http://wingolog.org/