From: Andy Wingo <wingo@pobox.com>
To: Mark H Weaver <mhw@netris.org>
Cc: guile-devel@gnu.org
Subject: Re: [Guile-commits] GNU Guile branch, master, updated. v2.1.0-213-gb43e81d
Date: Sat, 05 Oct 2013 13:22:29 +0200 [thread overview]
Message-ID: <87fvsg2c96.fsf@pobox.com> (raw)
In-Reply-To: <87bo35bra9.fsf@netris.org> (Mark H. Weaver's message of "Fri, 04 Oct 2013 00:20:46 -0400")
Hi,
On Fri 04 Oct 2013 06:20, Mark H Weaver <mhw@netris.org> writes:
> This lazy initialization pattern is not safe on modern weakly ordered
> memory architectures. I've already raised this issue on the mailing
> list more than once, and I've been trying to fix these bugs wherever I
> can find them, but they are non-trivial to search for. Please do not
> add more.
>
> We need to either use a mutex to guard both reads and writes of
> 'program_source' (including the "scm_is_false (program_source)" check),
> or we need to arrange for 'program_source' to be initialized during
> guile's initialization before any other threads are created.
I'm happy to fix up the ones that I introduce. There needs to be a
better abstraction for doing this lazy-init operation. I might not get
around to making that abstraction before introducing a few more though;
apologies in advance for that.
They are actually very easy to search for, though. Search for " static
SCM" and you've got all of them :)
Andy
--
http://wingolog.org/
prev parent reply other threads:[~2013-10-05 11:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1VRpou-0002qh-2M@vcs.savannah.gnu.org>
2013-10-04 4:20 ` [Guile-commits] GNU Guile branch, master, updated. v2.1.0-213-gb43e81d Mark H Weaver
2013-10-05 11:22 ` Andy Wingo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvsg2c96.fsf@pobox.com \
--to=wingo@pobox.com \
--cc=guile-devel@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).