From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Fix bug #24816: open-string-output-port extraction thunk does not truncate string port as expected by R6RS in Guile 2.1.7 Date: Wed, 01 Mar 2017 18:55:02 +0100 Message-ID: <87fuiwdgqx.fsf@pobox.com> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1488390933 15496 195.159.176.226 (1 Mar 2017 17:55:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 1 Mar 2017 17:55:33 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: guile-devel@gnu.org To: Freja Nordsiek Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Mar 01 18:55:27 2017 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cj8T9-0002j0-Sv for guile-devel@m.gmane.org; Wed, 01 Mar 2017 18:55:20 +0100 Original-Received: from localhost ([::1]:47978 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cj8TE-0000Va-Gt for guile-devel@m.gmane.org; Wed, 01 Mar 2017 12:55:24 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39283) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cj8T6-0000VJ-5w for guile-devel@gnu.org; Wed, 01 Mar 2017 12:55:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cj8T3-0005uk-02 for guile-devel@gnu.org; Wed, 01 Mar 2017 12:55:16 -0500 Original-Received: from pb-sasl1.pobox.com ([64.147.108.66]:60223 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cj8T2-0005uL-Sy for guile-devel@gnu.org; Wed, 01 Mar 2017 12:55:12 -0500 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-sasl1.pobox.com (Postfix) with ESMTP id 77B1F60527; Wed, 1 Mar 2017 12:55:11 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=LJ9Dw96mu1YhKA2t/g2HzXnkYlM=; b=utQIRy CfOGZDpzjI/1KPOW3bK+Wl35o+Wt9vYlx3uWBz2gUJhCNwzUEXdo6t+/PVWqIY2r 7VgQ0jXmXXzTvlWu4hs46p8da6Hx3CkTOXsUK8ItYORBaIWs+U9cTHDJnU2Cm5QP 0qq6wWYanLBvSDAoiM74fYfTE5xiE8DYl8Hak= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=M0C0ucY5ygAKtIwhJKRPYDFigb+DcI+G pehXAxA05DfbijfBASx0MYJQLY3i1z5KKKgGvmAtjQtvfUFx5HXvYm51tsQvmuhK 8qRQdDWR3UUCy2IZ/mOdgrCHity0kzj3e1xsjeTq0qBQ7j6+UC9SqzHV+OTO4uli oc+Kwhcwafs= Original-Received: from pb-sasl1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-sasl1.pobox.com (Postfix) with ESMTP id 619EF60525; Wed, 1 Mar 2017 12:55:11 -0500 (EST) Original-Received: from clucks (unknown [88.160.190.192]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-sasl1.pobox.com (Postfix) with ESMTPSA id 414A360523; Wed, 1 Mar 2017 12:55:10 -0500 (EST) In-Reply-To: (Freja Nordsiek's message of "Tue, 21 Feb 2017 20:36:20 +0100") X-Pobox-Relay-ID: 3691E8B0-FEA8-11E6-ACD7-B667064AB293-02397024!pb-sasl1.pobox.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 64.147.108.66 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.org gmane.lisp.guile.devel:18969 Archived-At: Heya Freja, On Tue 21 Feb 2017 20:36, Freja Nordsiek writes: > Patch for bug #24816: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24816 Apologies for not noticing this patch; I was working from the debbugs interface and didn't see this. In the future you can update a bug with a patch by CC'ing NNNNN@debbugs.gnu.org, e.g. 24816@debbugs.gnu.org. Your patch is pretty much exactly what I did, too :) One thing I did was require the port position to be within the bounds of the truncated size; was a tough call but truncate-file on a file doesn't adjust the position, so there's that. Thank you again for the patch and sorry for missing it. Looking forward to future patches :-) Andy