From: Andy Wingo <wingo@pobox.com>
To: Freja Nordsiek <fnordsie@gmail.com>
Cc: guile-devel@gnu.org
Subject: Re: [PATCH] Fix bug #24816: open-string-output-port extraction thunk does not truncate string port as expected by R6RS in Guile 2.1.7
Date: Wed, 01 Mar 2017 18:55:02 +0100 [thread overview]
Message-ID: <87fuiwdgqx.fsf@pobox.com> (raw)
In-Reply-To: <CAOqf98qhTO2USBDYTxo4XQFqCxPwfNvqXw_v9D-YxqeHLH4-AA@mail.gmail.com> (Freja Nordsiek's message of "Tue, 21 Feb 2017 20:36:20 +0100")
Heya Freja,
On Tue 21 Feb 2017 20:36, Freja Nordsiek <fnordsie@gmail.com> writes:
> Patch for bug #24816: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24816
Apologies for not noticing this patch; I was working from the debbugs
interface and didn't see this. In the future you can update a bug with
a patch by CC'ing NNNNN@debbugs.gnu.org, e.g. 24816@debbugs.gnu.org.
Your patch is pretty much exactly what I did, too :) One thing I did
was require the port position to be within the bounds of the truncated
size; was a tough call but truncate-file on a file doesn't adjust the
position, so there's that.
Thank you again for the patch and sorry for missing it. Looking forward
to future patches :-)
Andy
next prev parent reply other threads:[~2017-03-01 17:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 19:36 [PATCH] Fix bug #24816: open-string-output-port extraction thunk does not truncate string port as expected by R6RS in Guile 2.1.7 Freja Nordsiek
2017-03-01 17:55 ` Andy Wingo [this message]
2017-03-01 21:15 ` Freja Nordsiek
2017-03-02 7:43 ` Andy Wingo
2017-03-02 20:42 ` Freja Nordsiek
2017-03-06 19:49 ` Andy Wingo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fuiwdgqx.fsf@pobox.com \
--to=wingo@pobox.com \
--cc=fnordsie@gmail.com \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).