guile 2.1.7 skips while condition

guile 2.1.7 skips while condition

[Arne Babenhauserheide]

Hi,

I have a file in which guile 2.1.7 runs a loop like the following

    (while (not (eof-object? nextchar))
           (write (eof-object? nextchar))
           (set! nextchar (read-char)) ...)

But ends with #<eof>. Guile 2.0 does not show the #<eof>.

However I did not manage to reproduce it in a small example, therefore I
pastebinned the whole file:

script: https://paste.pound-python.org/show/0IlalBrxVH7KHjW83ayu/
input: https://paste.pound-python.org/show/ZxQsazFfwVrvz9f4SU4f/

The file has some added debug output (hence the #f#f#f ... in the output below)

call: guile script input

This results in the error:

$ wget -O script https://paste.pound-python.org/raw/0IlalBrxVH7KHjW83ayu/
$ wget -O input https://paste.pound-python.org/raw/ZxQsazFfwVrvz9f4SU4f/
$ guile script input
;;; note: auto-compilation is enabled, set GUILE_AUTO_COMPILE=0
;;;       or pass the --no-auto-compile argument to disable.
;;; compiling /tmp/script
;;; compiled /home/arne/.cache/guile/ccache/2.2-LE-8-3.9/tmp/script.go
#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#tBacktrace:
9 (apply-smob/1 #<catch-closure 715020>)
In ice-9/boot-9.scm:
713:2  8 (call-with-prompt _ _ #<procedure default-prompt-handle…>)
In ice-9/eval.scm:
608:8  7 (_ #(#(#<directory (guile-user) 7c96c0>)))
In ice-9/boot-9.scm:
2346:4  6 (save-module-excursion _)
3850:12  5 (_)
In /tmp/script:
831:17  4 (_)
816:20  3 (wisp2lisp _)
389:24  2 (linestoindented _)
364:57  1 (splitindent #<input: string 8b0150>)
In unknown file:
0 (string #<eof>)

ERROR: In procedure string:
ERROR: In procedure string: Wrong type (expecting character): #<eof>


while Guile 2.0 works:

$ guile-2.0 script input
;;; note: auto-compilation is enabled, set GUILE_AUTO_COMPILE=0
;;;       or pass the --no-auto-compile argument to disable.
;;; compiling /tmp/script
;;; compiled /home/arne/.cache/guile/ccache/2.0-LE-8-2.0/tmp/script.go
#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f; Test linebreaks in strings and brackets

"flubbub

flabbab"

(hrug (nadda
       madda gadda "shoktom
 mee"  " sep  
ka"
 hadda)
      (gom))

(flu)

(sum [foo
      bar] barz {1 + [* 2 2]})

(mara {
       li
       +
       lo - (mabba)
       })

Best wishes,
Arne

Re: guile 2.1.7 skips while condition

[Andy Wingo]

On Thu 09 Mar 2017 15:31, Arne Babenhauserheide <arne_bab@web.de> writes:

> However I did not manage to reproduce it in a small example, therefore I
> pastebinned the whole file:
>
> script: https://paste.pound-python.org/show/0IlalBrxVH7KHjW83ayu/
> input: https://paste.pound-python.org/show/ZxQsazFfwVrvz9f4SU4f/

Sounds like you found a nice bug.  This is a big script though; have you
tried incrementally removing parts of it to winnow it down?  That is
definitely the first step to fixing the bug :)

Andy

Re: guile 2.1.7 skips while condition

[Arne Babenhauserheide]

[-- Attachment #1: Type: text/plain, Size: 908 bytes --]


Andy Wingo <wingo@pobox.com> writes:

> On Thu 09 Mar 2017 15:31, Arne Babenhauserheide <arne_bab@web.de> writes:
>
>> However I did not manage to reproduce it in a small example, therefore I
>> pastebinned the whole file:
>>
>> script: https://paste.pound-python.org/show/0IlalBrxVH7KHjW83ayu/
>> input: https://paste.pound-python.org/show/ZxQsazFfwVrvz9f4SU4f/
>
> Sounds like you found a nice bug.  This is a big script though; have you
> tried incrementally removing parts of it to winnow it down?  That is
> definitely the first step to fixing the bug :)

I tried building a minimal working example, but not removing stuff bit
by bit (due to time constraints on free creative time). I would hope
that it shouldn’t be too complex, but cannot promise I’d get it done
within the next few weeks.

Best wishes,
Arne
-- 
Unpolitisch sein
heißt politisch sein
ohne es zu merken

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 800 bytes --]

Re: guile 2.1.7 skips while condition

[Arne Babenhauserheide]

Arne Babenhauserheide writes:

> Andy Wingo <wingo@pobox.com> writes:
>
>> On Thu 09 Mar 2017 15:31, Arne Babenhauserheide <arne_bab@web.de> writes:
>>
>>> However I did not manage to reproduce it in a small example, therefore I
>>> pastebinned the whole file:
>>>
>>> script: https://paste.pound-python.org/show/0IlalBrxVH7KHjW83ayu/
>>> input: https://paste.pound-python.org/show/ZxQsazFfwVrvz9f4SU4f/
>>
>> Sounds like you found a nice bug.  This is a big script though; have you
>> tried incrementally removing parts of it to winnow it down?  That is
>> definitely the first step to fixing the bug :)
>
> I tried building a minimal working example, but not removing stuff bit
> by bit (due to time constraints on free creative time). I would hope
> that it shouldn’t be too complex, but cannot promise I’d get it done
> within the next few weeks.

Here’s a shortened version:

$ wget -O script https://paste.pound-python.org/raw/xbrz8bRPSwPxFvR54kAc/
$ wget -O input https://paste.pound-python.org/raw/UvlhjC3woe0EKq1JiIhO/

$ guile-2.0 script input
#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f

$ guile-2.2 script input
#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#f#tBacktrace:
9 (apply-smob/1 #<catch-closure 715020>)
In ice-9/boot-9.scm:
713:2  8 (call-with-prompt _ _ #<procedure default-prompt-handle&>)
In ice-9/eval.scm:
608:8  7 (_ #(#(#<directory (guile-user) 7c96c0>)))
In ice-9/boot-9.scm:
2346:4  6 (save-module-excursion _)
3850:12  5 (_)
In /tmp/script:
348:17  4 (_)
340:20  3 (wisp2lisp _)
320:24  2 (linestoindented _)
295:57  1 (splitindent #<input: string 8b0150>)
In unknown file:
0 (string #<eof>)

ERROR: In procedure string:
ERROR: In procedure string: Wrong type (expecting character): #<eof>

Re: guile 2.1.7 skips while condition

[Andy Wingo]

On Mon 13 Mar 2017 18:09, Arne Babenhauserheide <arne_bab@web.de> writes:

> Here’s a shortened version:

Thanks.  Here's a shorter version :)

(call-with-input-string "A"
  (lambda (inport)
    (let ((nextchar (read-char inport)))
      (while (not (eof-object? nextchar))
        (pk nextchar)
        (set! nextchar (read-char inport))
        (continue)))))

Working on a fix.

Andy

Re: guile 2.1.7 skips while condition

[Andy Wingo]

On Mon 13 Mar 2017 18:09, Arne Babenhauserheide <arne_bab@web.de> writes:

> Arne Babenhauserheide writes:
>
>> Andy Wingo <wingo@pobox.com> writes:
>>
>>> On Thu 09 Mar 2017 15:31, Arne Babenhauserheide <arne_bab@web.de> writes:
>>>
>>>> However I did not manage to reproduce it in a small example, therefore I
>>>> pastebinned the whole file:
>>>>
>>>> script: https://paste.pound-python.org/show/0IlalBrxVH7KHjW83ayu/
>>>> input: https://paste.pound-python.org/show/ZxQsazFfwVrvz9f4SU4f/
>>>
>>> Sounds like you found a nice bug.  This is a big script though; have you
>>> tried incrementally removing parts of it to winnow it down?  That is
>>> definitely the first step to fixing the bug :)
>>
>> I tried building a minimal working example, but not removing stuff bit
>> by bit (due to time constraints on free creative time). I would hope
>> that it shouldn’t be too complex, but cannot promise I’d get it done
>> within the next few weeks.
>
> Here’s a shortened version:

Or even smaller:

(define (t)
  (let ((n #t))
    (let lp ()
      (when n
        (call-with-prompt 'foo
          (lambda ()
            (set! n #f)
            (abort-to-prompt 'foo))
          (lambda (k)
            (lp)))))))

Guile is thinking that the n is always true because it doesn't
understand that aborting back to the prompt means that possible all
mutable objects are mutated.

Andy

Re: guile 2.1.7 skips while condition

[Andy Wingo]

On Mon 13 Mar 2017 18:09, Arne Babenhauserheide <arne_bab@web.de> writes:

> ERROR: In procedure string:
> ERROR: In procedure string: Wrong type (expecting character): #<eof>

Fixed, I think.  Thanks for the report.

Andy

Re: guile 2.1.7 skips while condition

[Arne Babenhauserheide]

Andy Wingo writes:

> On Mon 13 Mar 2017 18:09, Arne Babenhauserheide <arne_bab@web.de> writes:
>
>> ERROR: In procedure string:
>> ERROR: In procedure string: Wrong type (expecting character): #<eof>
>
> Fixed, I think.  Thanks for the report.

That’s awesome! Thank you!

Best wishes,
Arne

PS: I did not test the fix, yet.