From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Newsgroups: gmane.lisp.guile.devel,gmane.lisp.guile.user Subject: Re: mmap for guile Date: Mon, 04 Jul 2022 22:03:41 +0200 Message-ID: <87fsjg8x2a.fsf@gnu.org> References: <56ee7537-1666-3d04-7093-732a75624e9b@gmail.com> <0cf4e4ee80169487694b844996e04f3293eab92f.camel@telenet.be> <87k08tfau0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30839"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) Cc: guile-user@gnu.org, guile-devel@gnu.org To: Greg Troxel Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Mon Jul 04 22:04:16 2022 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8SIq-0007nL-4N for guile-devel@m.gmane-mx.org; Mon, 04 Jul 2022 22:04:16 +0200 Original-Received: from localhost ([::1]:53034 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8SIo-0001F7-Nw for guile-devel@m.gmane-mx.org; Mon, 04 Jul 2022 16:04:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47072) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8SIK-0001Ev-3O; Mon, 04 Jul 2022 16:03:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40674) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8SIJ-0001g9-Iu; Mon, 04 Jul 2022 16:03:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=DhjHRIbOiKhm51/4QknXiVt/frtaCWbtrqXX5qowWQo=; b=iNo2DsvSp+hgrYslAgtq 9WJV7CWvgQMpzw6eaU//tYtuUQziklHVBHQ3OKWb20Fg2t6GBXOj9wq1DCmTTWnOtPniGavvd848S fDi6Rh4LzsI08o5xs3zqhkYtne48jN3O4cNMobZdBzvZ0lSAq52zA2RpNbSVkUzV2x0Z8z0DcCL1x nei7i5OJ4MbK214ubrzqY/5uHG3y1j4kbUBvl1EXGnrMjzmavRcZzUHmJ4cpsgXDcYVYSGEdapJgr kh6BDx2/C4owg2adx7lrQeEpM81ej0pYMW04UPHaTzMHPWAm8IkKRaa7hw1yooAwJju2vBTVg79eN mKG+ze5HqeFTIw==; Original-Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:63417 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8SIJ-0006dj-5e; Mon, 04 Jul 2022 16:03:43 -0400 X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Sextidi 16 Messidor an 230 de la =?utf-8?Q?R=C3=A9vo?= =?utf-8?Q?lution=2C?= jour du Tabac X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu In-Reply-To: (Greg Troxel's message of "Mon, 04 Jul 2022 09:14:17 -0400") X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.io gmane.lisp.guile.devel:21253 gmane.lisp.guile.user:18393 Archived-At: Hi, Greg Troxel skribis: > Ludovic Court=C3=A8s writes: > >> Besides what Maxime points out, some more superficial issues: >> >> =E2=80=A2 In documentation, please refer to the relevant glibc section= instead >> of =E2=80=9CSee man page=E2=80=9D (info "(libc) Memory-mapped I/O"). >> >> =E2=80=A2 Please update doc/ref with a section on memory-mapped I/O. >> >> =E2=80=A2 Make sure to follow the GNU coding in C: space before openin= g paren, >> braces on a line of their own, etc. > > I have been meaning to try to build this under NetBSD, to check > portability. I think the mmap code should by default rely only on what > POSIX guarantees: > https://pubs.opengroup.org/onlinepubs/9699919799/functions/mmap.html Agreed. > As for referring to glibc, that reference only resolves on GNU/Linux > systems, whereas any POSIX system ought to have an mmap man page, so it > would be nice not to drop the man page ref, esp. as it grounds the > implementation as being about the POSIX interface. The manual can mention the man page too, sure, but note that the manual already refers to glibc=E2=80=99s for all things libc. Ludo=E2=80=99.