From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Josselin Poiret Newsgroups: gmane.lisp.guile.devel Subject: Re: pull requests for guile Date: Mon, 08 May 2023 18:27:40 +0200 Message-ID: <87fs866b5v.fsf@jpoiret.xyz> References: <781a3ed7-6fcd-b502-a03b-6ae63279be75@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18462"; mail-complaints-to="usenet@ciao.gmane.io" Cc: guile-devel@gnu.org To: Dmitry Alexandrov , Matt Wette Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Mon May 08 18:28:25 2023 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pw3ir-0004ZZ-7F for guile-devel@m.gmane-mx.org; Mon, 08 May 2023 18:28:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pw3iM-0002Ng-M5; Mon, 08 May 2023 12:27:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pw3iK-0002NR-6q for guile-devel@gnu.org; Mon, 08 May 2023 12:27:52 -0400 Original-Received: from jpoiret.xyz ([206.189.101.64]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pw3iH-0004NP-Ep for guile-devel@gnu.org; Mon, 08 May 2023 12:27:51 -0400 Original-Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 36752184D70; Mon, 8 May 2023 16:27:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1683563263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RFlo0pTa7bjL6++Z/DfRhhNvoaMR3qzpZpFvcLn1ueg=; b=lRJXdM97lc2ZcP747zrCKF7LFlrY48ejvv+cy4qKfewcy/wuABVY6rSzg7NyEJae6DQJIf Dbg68YBDKR+45hW4wzMVpL4uMWnjuQ4tG8ZC8KnmW9t4BdqfSJGbTP3beGELT96vkXniA5 2dRj/zFsFSOk1xQ2CACo5qgEcyI146jc8frPC3PUpUAFCzhYBXgpGXZcpkfljU8GIiUeo9 0E7fW4g7wTNTiab+TyBZcH/OmHnR7xv9IZ/F+CWKTDS+8F+UL1OEPuW76yfhsceUtshMQ2 aoFMaz2KSWf34jomNG/ytQsmobCBl/71Ik25XVh6CQwZyNeKmNnTYdGS+bodag== In-Reply-To: X-Spamd-Bar: -- Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz Received-SPF: pass client-ip=206.189.101.64; envelope-from=dev@jpoiret.xyz; helo=jpoiret.xyz X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.devel:21826 Archived-At: --=-=-= Content-Type: text/plain Hey Dmitry and Matt, First off, `git-request-pull` requires the user to have their own repository hosted somewhere, and someone would need to clone it/add a remote and fetch from it just to check out what's inside. That means extra steps with no real benefits. Dmitry Alexandrov writes: > The only thing the I am aware of is git-am, which provides... nothing (?) over a simple pull request. Reciprocally, I don't think a simple pull request provides much over git-am, except that with `format-patch`, everything is simply text, that once sent over email (in a decentralized fashion) can be simply responded to and read without relying on complicated javascript in a browser, and using your mail reader of choice. Applying a patchset is pretty easy with tools like b4, lei and friends. Also, patches lend themselves much better to an iteration workflow, I know that at least GitHub doesn't like when people rewrite PR history, which is imo the only solution to get a clean git history in the end. Best, -- Josselin Poiret --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHEBAEBCgAuFiEEOSSM2EHGPMM23K8vUF5AuRYXGooFAmRZIv0QHGRldkBqcG9p cmV0Lnh5egAKCRBQXkC5FhcaitDhDACzFjnjj3qDym/Qty7937PhJ+r7/DNjIadc 4MAjyLdnqlm1Bm6fDEMWHlui7yWYLXZlRRluaPB12FooaJhq/1TWyXPG4aFNyyof inFIS1YIKO4hXysQcAUqx7hoCmwSb2wjePfeO9tpJYIwvCQOlmxy1XZZOC4bem7x y59MyBQRwPWZkZ/Y4FsbzVomsSNYBDRbf0Tgx+wGQ+4/BmED6vgBQQGZSkYuDnMK jIwnsr6yzFjG0iU8NQFO94rj1qtoYXsa/U9o0E7qJarBR0OFciP5QsCtfTGuaTE8 4E3j2gbbMdBknXOw0biIwU82XSoS5ZS5egj70N1LwXxg1p9Qes+Hmn/uv0d1n4a5 0m8E939dfdcOohGSQayYPj+YPmpZuIDJEfwmAEhUdlBWE99RKMUy+RK0U1T7BiUi HmOp2Vl5wjTL3/qqhgSgLD+BGmdBrhmMCvr/LgeuEK6Q/adjksBMDukPwTt9jJ7O hqG88OzN4q5/Vb4fnV/dS52JTXMGzLQ= =uWzq -----END PGP SIGNATURE----- --=-=-=--