unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Josselin Poiret <dev@jpoiret.xyz>
To: Dmitry Alexandrov <dag@gnui.org>, Matt Wette <matt.wette@gmail.com>
Cc: guile-devel@gnu.org
Subject: Re: pull requests for guile
Date: Mon, 08 May 2023 18:27:40 +0200	[thread overview]
Message-ID: <87fs866b5v.fsf@jpoiret.xyz> (raw)
In-Reply-To: <mt2f83f1.dag@gnui.org>

[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]

Hey Dmitry and Matt,

First off, `git-request-pull` requires the user to have their own
repository hosted somewhere, and someone would need to clone it/add a
remote and fetch from it just to check out what's inside.  That means
extra steps with no real benefits.

Dmitry Alexandrov <dag@gnui.org> writes:

> The only thing the I am aware of is git-am, which provides... nothing (?) over a simple pull request.

Reciprocally, I don't think a simple pull request provides much over
git-am, except that with `format-patch`, everything is simply text, that
once sent over email (in a decentralized fashion) can be simply
responded to and read without relying on complicated javascript in a
browser, and using your mail reader of choice.  Applying a patchset is
pretty easy with tools like b4, lei and friends.

Also, patches lend themselves much better to an iteration workflow, I
know that at least GitHub doesn't like when people rewrite PR history,
which is imo the only solution to get a clean git history in the end.

Best,
--
Josselin Poiret

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 682 bytes --]

  reply	other threads:[~2023-05-08 16:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-06 16:21 pull requests for guile Matt Wette
2023-05-08 11:32 ` Dmitry Alexandrov
2023-05-08 16:27   ` Josselin Poiret [this message]
2023-05-08 21:03     ` Dr. Arne Babenhauserheide
2023-05-08 17:03 ` Arsen Arsenović

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fs866b5v.fsf@jpoiret.xyz \
    --to=dev@jpoiret.xyz \
    --cc=dag@gnui.org \
    --cc=guile-devel@gnu.org \
    --cc=matt.wette@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).