From: Ricardo Wurmus <rekado@elephly.net>
To: Adam Faiz <adam.faiz@disroot.org>
Cc: guile-devel@gnu.org
Subject: Re: rdelim: Add new procedure `for-line-in-file`.
Date: Mon, 16 Dec 2024 08:42:10 +0100 [thread overview]
Message-ID: <87frmohy5p.fsf@elephly.net> (raw)
In-Reply-To: <ae34e007-3dc4-e6bf-873d-0d37f37f41e9@disroot.org> (Adam Faiz's message of "Mon, 16 Dec 2024 10:29:02 +0800")
Hi Adam,
> On 12/16/24 00:57, Ricardo Wurmus wrote:
>> Hi Adam,
>>
>> has this patch been discussed somewhere else? I'm asking because I have
>> no context other than this patch.
>
> No, actually. Was I supposed to discuss it's use in the patch cover letter?
No, there is no requirement to do so. I just wanted to make sure I'm
not bothering you by poking at things that had previously been agreed
upon with other developers.
Explaining the patch in the preamble / commit message would be a good
idea for future patches, though.
>> Where is BREAK defined?
>
> Break is defined by the ‘while’ loop:
> https://www.gnu.org/software/guile/manual/html_node/while-do.html
Ah, right, I missed it. Thanks!
--
Ricardo
prev parent reply other threads:[~2024-12-16 7:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-15 16:00 rdelim: Add new procedure `for-line-in-file` Adam Faiz
2024-12-15 16:57 ` Ricardo Wurmus
2024-12-15 20:33 ` Maxime Devos
2024-12-16 2:29 ` Adam Faiz
2024-12-16 7:42 ` Ricardo Wurmus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frmohy5p.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=adam.faiz@disroot.org \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).