From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Jan Nieuwenhuizen Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH]: Cross building and Cygwin fixes. Date: Mon, 08 Jul 2002 11:52:57 +0200 Organization: Jan at Appel Sender: guile-devel-admin@gnu.org Message-ID: <87eleebl6u.fsf@peder.flower> References: <87r8ikdbj6.fsf@peder.flower> <87hejb6ztn.fsf@zagadka.ping.de> NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1026122043 18742 127.0.0.1 (8 Jul 2002 09:54:03 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 8 Jul 2002 09:54:03 +0000 (UTC) Cc: guile-devel@gnu.org, Han-Wen Return-path: Original-Received: from fencepost.gnu.org ([199.232.76.164]) by main.gmane.org with esmtp (Exim 3.33 #1 (Debian)) id 17RVDV-0004ri-00 for ; Mon, 08 Jul 2002 11:54:02 +0200 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.35 #1 (Debian)) id 17RVDW-00049d-00; Mon, 08 Jul 2002 05:54:02 -0400 Original-Received: from node-d-3053.a2000.nl ([62.195.48.83] helo=peder.flower) by fencepost.gnu.org with esmtp (Exim 3.35 #1 (Debian)) id 17RVCX-0003zy-00 for ; Mon, 08 Jul 2002 05:53:01 -0400 Original-Received: from localhost.localdomain ([127.0.0.1] helo=peder.flower) by peder.flower with esmtp (Exim 3.35 #1 (Debian)) id 17RVCU-0002pV-00; Mon, 08 Jul 2002 11:52:58 +0200 Original-To: Marius Vollmer In-Reply-To: <87hejb6ztn.fsf@zagadka.ping.de> (Marius Vollmer's message of "07 Jul 2002 22:35:48 +0200") Original-Lines: 60 User-Agent: Gnus/5.090006 (Oort Gnus v0.06) Emacs/21.2 (i386-debian-linux-gnu) Errors-To: guile-devel-admin@gnu.org X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Developers list for Guile, the GNU extensibility library List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.lisp.guile.devel:753 X-Report-Spam: http://spam.gmane.org/gmane.lisp.guile.devel:753 Marius Vollmer writes: > Thanks! I have applied it (with some changes, see below) to the > 'unstable' branch. It is too late for 1.6. Ah, that's very nice. Being too late is only a small setback, I'm glad not having to maintain a patch against CVS; as I'm maintaining Guile officially for Cygwin now. > I changed this to just > > GUILE_FOR_BUILD='$(preinstguile)' > > but did not change am/preinstguile. This keeps the roles of the > 'pre-inst-guile' separate from the 'guile-for-build'. pre-inst-guile > is used during "make check" for example, and guile-for-build is used > for the doc snarfing. Ok. >> +test -n "$with_guile_for_build" && GUILE_FOR_BUILD="$with_cc_for_build" > > "GUILE" instead of "CC", no? Sure, thanks. >> +2002-07-03 Jan Nieuwenhuizen >> + >> + * pre-inst-guile (preinstguile): Initialize with >> + $(GUILE_FOR_BUILD) configure parameter. > > I didn't make this change, see above. Instead, I defined > snarf2checkedtexi as > > GUILE="$(GUILE_FOR_BUILD)" $(top_srcdir)/scripts/snarf-check-and-output-texi Ok, looks good. I'll have a look at CVS today. >> -#ifdef HAVE_WINSOCK2_H >> +#if defined (HAVE_WINSOCK2_H) \ >> + && !(defined (__CYGWIN32__) || defined (__CYGWIN__)) >> #include >> #endif > > What is the reason for this change? The reason is that Cygwin has the winsock header, but it also has unix sockets. We don't want winsock. > Wouldn't it be better to fix the check for in > configure.in? Possibly. But then it's not a HAVE_WINSOCK2, but rather a WANT_WINSOCK2. If configure.in only changes 'have' into want if not Cygwin, that would maybe be cleaner. Jan. -- Jan Nieuwenhuizen | GNU LilyPond - The music typesetter http://www.xs4all.nl/~jantien | http://www.lilypond.org _______________________________________________ Guile-devel mailing list Guile-devel@gnu.org http://mail.gnu.org/mailman/listinfo/guile-devel