From: Jan Nieuwenhuizen <janneke@gnu.org>
Cc: guile-devel@gnu.org, Han-Wen <hanwen@cs.uu.nl>
Subject: Re: [PATCH]: Cross building and Cygwin fixes.
Date: Mon, 08 Jul 2002 11:52:57 +0200 [thread overview]
Message-ID: <87eleebl6u.fsf@peder.flower> (raw)
In-Reply-To: <87hejb6ztn.fsf@zagadka.ping.de> (Marius Vollmer's message of "07 Jul 2002 22:35:48 +0200")
Marius Vollmer <mvo@zagadka.ping.de> writes:
> Thanks! I have applied it (with some changes, see below) to the
> 'unstable' branch. It is too late for 1.6.
Ah, that's very nice. Being too late is only a small setback, I'm
glad not having to maintain a patch against CVS; as I'm maintaining
Guile officially for Cygwin now.
> I changed this to just
>
> GUILE_FOR_BUILD='$(preinstguile)'
>
> but did not change am/preinstguile. This keeps the roles of the
> 'pre-inst-guile' separate from the 'guile-for-build'. pre-inst-guile
> is used during "make check" for example, and guile-for-build is used
> for the doc snarfing.
Ok.
>> +test -n "$with_guile_for_build" && GUILE_FOR_BUILD="$with_cc_for_build"
>
> "GUILE" instead of "CC", no?
Sure, thanks.
>> +2002-07-03 Jan Nieuwenhuizen <janneke@gnu.org>
>> +
>> + * pre-inst-guile (preinstguile): Initialize with
>> + $(GUILE_FOR_BUILD) configure parameter.
>
> I didn't make this change, see above. Instead, I defined
> snarf2checkedtexi as
>
> GUILE="$(GUILE_FOR_BUILD)" $(top_srcdir)/scripts/snarf-check-and-output-texi
Ok, looks good. I'll have a look at CVS today.
>> -#ifdef HAVE_WINSOCK2_H
>> +#if defined (HAVE_WINSOCK2_H) \
>> + && !(defined (__CYGWIN32__) || defined (__CYGWIN__))
>> #include <winsock2.h>
>> #endif
>
> What is the reason for this change?
The reason is that Cygwin has the winsock header, but it also has unix
sockets. We don't want winsock.
> Wouldn't it be better to fix the check for <winsock2.h> in
> configure.in?
Possibly. But then it's not a HAVE_WINSOCK2, but rather a
WANT_WINSOCK2. If configure.in only changes 'have' into want if not
Cygwin, that would maybe be cleaner.
Jan.
--
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond - The music typesetter
http://www.xs4all.nl/~jantien | http://www.lilypond.org
_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/guile-devel
next prev parent reply other threads:[~2002-07-08 9:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-03 16:25 [PATCH]: Cross building and Cygwin fixes Jan Nieuwenhuizen
2002-07-07 20:35 ` Marius Vollmer
2002-07-08 9:04 ` Han-Wen Nienhuys
2002-07-08 18:12 ` Marius Vollmer
2002-07-08 9:52 ` Jan Nieuwenhuizen [this message]
2002-07-09 18:08 ` Marius Vollmer
2002-07-10 0:37 ` Jan Nieuwenhuizen
2002-07-10 19:34 ` Marius Vollmer
2002-07-10 19:52 ` Marius Vollmer
2002-07-10 20:02 ` Jan Nieuwenhuizen
-- strict thread matches above, loose matches on Subject: below --
2002-07-03 17:06 Jan Nieuwenhuizen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eleebl6u.fsf@peder.flower \
--to=janneke@gnu.org \
--cc=guile-devel@gnu.org \
--cc=hanwen@cs.uu.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).