From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Neil Jerram Newsgroups: gmane.lisp.guile.devel Subject: Re: Patch to fix working of autogen.sh Date: Tue, 06 Feb 2007 23:19:52 +0000 Message-ID: <87ejp2oovb.fsf@ossau.uklinux.net> References: <87d54z4hat.fsf@ossau.uklinux.net> <87odoh8kd9.fsf@zip.com.au> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1170804106 4801 80.91.229.12 (6 Feb 2007 23:21:46 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 6 Feb 2007 23:21:46 +0000 (UTC) To: Guile Development Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Feb 07 00:21:42 2007 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HEZd7-0002sS-JL for guile-devel@m.gmane.org; Wed, 07 Feb 2007 00:21:41 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HEZd7-0001IY-CB for guile-devel@m.gmane.org; Tue, 06 Feb 2007 18:21:41 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HEZbu-0000cs-KH for guile-devel@gnu.org; Tue, 06 Feb 2007 18:20:26 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HEZbt-0000bh-8I for guile-devel@gnu.org; Tue, 06 Feb 2007 18:20:25 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HEZbt-0000bY-3A for guile-devel@gnu.org; Tue, 06 Feb 2007 18:20:25 -0500 Original-Received: from mail3.uklinux.net ([80.84.72.33]) by monty-python.gnu.org with esmtp (Exim 4.52) id 1HEZbs-0006zS-Iz for guile-devel@gnu.org; Tue, 06 Feb 2007 18:20:24 -0500 Original-Received: from laruns (host86-145-157-83.range86-145.btcentralplus.com [86.145.157.83]) by mail3.uklinux.net (Postfix) with ESMTP id 390A240A722 for ; Tue, 6 Feb 2007 23:20:23 +0000 (UTC) Original-Received: from laruns (laruns [127.0.0.1]) by laruns (Postfix) with ESMTP id B290A6F78E for ; Tue, 6 Feb 2007 23:19:52 +0000 (GMT) In-Reply-To: <87odoh8kd9.fsf@zip.com.au> (Kevin Ryde's message of "Tue, 30 Jan 2007 10:48:50 +1100") User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux) X-detected-kernel: Linux 2.4-2.6 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:6512 Archived-At: Kevin Ryde writes: > Neil Jerram writes: >> >> (Doing AM_GNU_GETTEXT_VERSION causes autopoint to be run, which causes >> the creation of a po subdir, with various boilerplate files, but I see >> no harm in that.) > > An actual release doesn't have a po subdir yet does it? Not sure, haven't tried a make dist yet. I suspect that it would do, and agree with you that it shouldn't! > Can you make the autogen give what should go out the door? That's the intention. > It might mean running the desired aclocal/autoconf/automake > combination explicitly, instead of trusting autoreconf -- I'm > guessing autoreconf is wrongly (for us) deciding it needs to > gettextize. OK, here's the full trail as I understand it. My preference would be to stick with autoreconf, as I assume the autoreconf guys have thought more carefully about all the edge cases in this magic than we have. We start off with two problems. (1) autoreconf exits with error status, because it thinks that the expansion of AM_GNU_GETTEXT requires a definition of AM_INTL_SUBDIR, and AM_INTL_SUBDIR isn't defined. (2) If you get past (1), one of the subsequent build steps (forget which one) fails because there is no config.rpath in the top level directory. I understand that (1) is caused by an inconsistency between aclocal and autoconf. When aclocal decides what macros we need in aclocal.m4, it correctly decides that we don't need AM_INTL_SUBDIR. When autoconf checks that we have all the macros that we need, it incorrectly thinks we do need AM_INTL_SUBDIR. In fact, we don't need the real AM_INTL_SUBDIR, so (1) can be fixed by adding an empty definition for AM_INTL_SUBDIR. For (2): - config.rpath is apparently required for linking to the gettext library (which Guile genuinely needs, I believe), and it is installed, if not already present by autopoint - autopoint only runs, however, if configure.in contains both AM_GNU_GETTEXT and AM_GNU_GETTEXT_VERSION - therefore I solved (2) by adding AM_GNU_GETTEXT_VERSION ... - ... but unfortunately, then autopoint also generates the po directory and boilerplate files. So now, I believe there are two options. 1. Leave as is, and live with the po directory - probably even in the dist. 2. Remove AM_GNU_GETTEXT_VERSION, so autopoint doesn't run, and instead add config.rpath to CVS and EXTRA_DIST. We could make (1) more palatable by actually starting to internationalize Guile's internal strings - so then we would really need the po directory! On the other hand, (2) has the benefit that it should allow the nightly snapshot to build. (I now know from the build machine's log that the snapshot is failing because autopoint is not installed on the build machine.) >> + >> +AC_DEFUN([AM_INTL_SUBDIR], [])dnl > > Put an enormous comment there if you would, otherwise it's bound to > make everyone wonder what it's for. Will do. Let's just agree the whole solution first though. > (Oh, and no need for the dnl on the end, autoconf prunes newlines out > ok.) Thanks, I'll remove it. Regards, Neil _______________________________________________ Guile-devel mailing list Guile-devel@gnu.org http://lists.gnu.org/mailman/listinfo/guile-devel