From: Andy Wingo <wingo@pobox.com>
To: Mark H Weaver <mhw@netris.org>
Cc: guile-devel@gnu.org
Subject: Re: [PATCH] Universally-unique gensyms
Date: Tue, 17 Jan 2012 14:57:56 +0100 [thread overview]
Message-ID: <87ehuyh1nf.fsf@pobox.com> (raw)
In-Reply-To: <87hazu1msh.fsf@netris.org> (Mark H. Weaver's message of "Tue, 17 Jan 2012 08:27:58 -0500")
Hi Mark,
Excellent!
On Tue 17 Jan 2012 14:27, Mark H Weaver <mhw@netris.org> writes:
> This patch makes our gensyms universally-unique. Comments welcome.
I think the lazy initialization needs to happen within the lock. Also
it would be nice to factor out the initialization of the random seed
would be a nice helper to have in random.[ch]. You probably don't need
to have a flag to support /dev/random (rather than urandom), because
after all it's only seeding a PRNG (and not a cryptographically safe
one, at that).
Otherwise looks great to me!
Andy
--
http://wingolog.org/
next prev parent reply other threads:[~2012-01-17 13:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 13:27 [PATCH] Universally-unique gensyms Mark H Weaver
2012-01-17 13:57 ` Andy Wingo [this message]
2012-01-17 14:06 ` Andy Wingo
2012-01-18 8:04 ` Mark H Weaver
2012-01-18 9:35 ` Mark H Weaver
2012-01-18 21:41 ` Ludovic Courtès
2012-01-18 22:23 ` Andy Wingo
2012-01-18 22:43 ` Ludovic Courtès
2012-01-18 23:30 ` Mark H Weaver
2012-01-19 1:21 ` David Kastrup
2012-01-19 4:50 ` Mark H Weaver
2012-01-19 6:25 ` David Kastrup
2012-01-19 10:23 ` Mark H Weaver
2012-01-20 0:50 ` Mark H Weaver
2012-01-19 0:58 ` Mark H Weaver
2012-01-19 23:26 ` Ludovic Courtès
2012-01-18 21:42 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehuyh1nf.fsf@pobox.com \
--to=wingo@pobox.com \
--cc=guile-devel@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).