unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: guile-devel@gnu.org
Subject: Re: [PATCH] Per-port read options, reader directives, SRFI-105
Date: Tue, 23 Oct 2012 23:30:06 +0200	[thread overview]
Message-ID: <87ehko98rl.fsf@gnu.org> (raw)
In-Reply-To: 87mwzdzpqf.fsf@tines.lan

Mark H Weaver <mhw@netris.org> skribis:

> From 2ee3bdba0ae59e6f52a9fde61ac24f219db158fa Mon Sep 17 00:00:00 2001
> From: Mark H Weaver <mhw@netris.org>
> Date: Tue, 23 Oct 2012 00:58:38 -0400
> Subject: [PATCH 8/9] Implement #!fold-case and #!no-fold-case reader
>  directives.
>
> * libguile/read.c (set_per_port_case_insensitive_p): New internal static
>   function.
>
>   (scm_read_shebang): Handle #!fold-case and #!no-fold-case.
>
> * doc/ref/api-evaluation.texi (Case Sensitivity, Scheme Read): Document
>   #!fold-case and #!no-fold-case reader directives.
>
> * test-suite/tests/reader.test ("per-port-read-options"): Add tests.

OK.

> +read options on a per-port basis.  Currently, the only read option that
> +is overridden in this way is the @code{case-insensitive} option, which

Instead of “Currently, the only...”, perhaps “For instance, the
@code{case-insensitive} option can be...”?

> +/* Set case-insensitivity on a per-port basis. */
> +static void
> +set_per_port_case_insensitive_p (SCM port, scm_t_read_opts *opts, int value)

Comment: Set OPTS and PORT’s case-insensitivity according to VALUE.

Ludo’.




  parent reply	other threads:[~2012-10-23 21:30 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-16 10:32 [PATCH] Per-port read options, reader directives, SRFI-105 Mark H Weaver
2012-10-23  6:06 ` Mark H Weaver
2012-10-23 20:44   ` Ludovic Courtès
2012-10-23 20:45   ` Ludovic Courtès
2012-10-23 20:53   ` Ludovic Courtès
2012-10-23 20:54   ` Ludovic Courtès
2012-10-23 20:57   ` Ludovic Courtès
2012-10-23 20:58   ` Ludovic Courtès
2012-10-23 21:26   ` Ludovic Courtès
2012-10-24  4:04     ` Mark H Weaver
2012-10-24 13:13       ` Ludovic Courtès
2012-10-24 14:41         ` Mark H Weaver
2012-10-26 17:30           ` Ludovic Courtès
2012-10-23 21:30   ` Ludovic Courtès [this message]
2012-10-24 19:00   ` Mark H Weaver
2012-10-24 21:52     ` David A. Wheeler
2012-10-26 17:41     ` Ludovic Courtès
2012-10-26 17:44     ` Ludovic Courtès
2012-10-26 21:21     ` Ludovic Courtès
2012-10-27  1:33       ` Mark H Weaver
2012-10-29 11:14         ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ehko98rl.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guile-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).