From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Add parse-path-with-ellipsis, and use it for GUILE_LOAD_PATH et al Date: Thu, 29 Nov 2012 00:46:55 +0100 Message-ID: <87ehjd9tow.fsf@gnu.org> References: <87sj8o20v0.fsf@googlemail.com> <87liecucrz.fsf@delenn.home.rotty.xx.vu> <87k3tpkyeg.fsf@gnu.org> <87624pxqxi.fsf_-_@tines.lan> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1354146435 9956 80.91.229.3 (28 Nov 2012 23:47:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 28 Nov 2012 23:47:15 +0000 (UTC) Cc: guile-devel@gnu.org To: Mark H Weaver Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Thu Nov 29 00:47:26 2012 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TdrLf-00012L-Bs for guile-devel@m.gmane.org; Thu, 29 Nov 2012 00:47:23 +0100 Original-Received: from localhost ([::1]:48209 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TdrLU-0001yG-4o for guile-devel@m.gmane.org; Wed, 28 Nov 2012 18:47:12 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:39637) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TdrLR-0001xz-8I for guile-devel@gnu.org; Wed, 28 Nov 2012 18:47:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TdrLP-0004XA-Li for guile-devel@gnu.org; Wed, 28 Nov 2012 18:47:09 -0500 Original-Received: from [2a01:e0b:1:123:ca0a:a9ff:fe03:271e] (port=38096 helo=xanadu.aquilenet.fr) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TdrLP-0004Vh-AH for guile-devel@gnu.org; Wed, 28 Nov 2012 18:47:07 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by xanadu.aquilenet.fr (Postfix) with ESMTP id 4121DADD6; Thu, 29 Nov 2012 00:46:56 +0100 (CET) Original-Received: from xanadu.aquilenet.fr ([127.0.0.1]) by localhost (xanadu.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U6hwV8arBfqR; Thu, 29 Nov 2012 00:46:56 +0100 (CET) Original-Received: from pluto (reverse-83.fdn.fr [80.67.176.83]) by xanadu.aquilenet.fr (Postfix) with ESMTPSA id AD221ABFB; Thu, 29 Nov 2012 00:46:55 +0100 (CET) X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 9 Frimaire an 221 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu In-Reply-To: <87624pxqxi.fsf_-_@tines.lan> (Mark H. Weaver's message of "Wed, 28 Nov 2012 18:12:41 -0500") User-Agent: Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.2 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2a01:e0b:1:123:ca0a:a9ff:fe03:271e X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:15271 Archived-At: Hi Mark, Mark H Weaver skribis: > From 4a78f4a638334a5bd8eb08308891b541bbde9b1e Mon Sep 17 00:00:00 2001 > From: Mark H Weaver > Date: Wed, 28 Nov 2012 18:01:35 -0500 > Subject: [PATCH] Add parse-path-with-ellipsis, and use it for GUILE_LOAD_= PATH > et al. > > * libguile/load.c (scm_parse_path_with_ellipsis): New procedure. > (scm_init_load_path): Use 'scm_parse_path_with_ellipsis' to > handle GUILE_LOAD_PATH and GUILE_LOAD_COMPILED_PATH. > > * libguile/load.h (scm_parse_path_with_ellipsis): Add prototype. > > * doc/ref/api-evaluation.texi (Load Paths): Add docs. > --- > doc/ref/api-evaluation.texi | 9 +++++++++ > libguile/load.c | 31 +++++++++++++++++++++++++++++-- > libguile/load.h | 1 + > 3 files changed, 39 insertions(+), 2 deletions(-) [...] > +a list and return the resulting list with @var{base} (a list) spliced in > +place of the @code{...} path component, if present, or else @var{base} > +is added to the end. If @var{path} is @code{#f}, @var{base} is > +returned. Looks clean to me. > +#define FUNC_NAME s_scm_parse_path_with_ellipsis > +{ > + SCM ellipsis =3D scm_from_latin1_string ("..."); Use =E2=80=98SCM_SYMBOL=E2=80=99 instead. Modulo that, feel free to commit. Thanks for working on this! Ludo=E2=80=99. PS: I=E2=80=99ve started updating NEWS.