From: ludo@gnu.org (Ludovic Courtès)
To: Mark H Weaver <mhw@netris.org>
Cc: guile-devel@gnu.org
Subject: Re: [PATCH] Add parse-path-with-ellipsis, and use it for GUILE_LOAD_PATH et al
Date: Thu, 29 Nov 2012 00:46:55 +0100 [thread overview]
Message-ID: <87ehjd9tow.fsf@gnu.org> (raw)
In-Reply-To: <87624pxqxi.fsf_-_@tines.lan> (Mark H. Weaver's message of "Wed, 28 Nov 2012 18:12:41 -0500")
Hi Mark,
Mark H Weaver <mhw@netris.org> skribis:
> From 4a78f4a638334a5bd8eb08308891b541bbde9b1e Mon Sep 17 00:00:00 2001
> From: Mark H Weaver <mhw@netris.org>
> Date: Wed, 28 Nov 2012 18:01:35 -0500
> Subject: [PATCH] Add parse-path-with-ellipsis, and use it for GUILE_LOAD_PATH
> et al.
>
> * libguile/load.c (scm_parse_path_with_ellipsis): New procedure.
> (scm_init_load_path): Use 'scm_parse_path_with_ellipsis' to
> handle GUILE_LOAD_PATH and GUILE_LOAD_COMPILED_PATH.
>
> * libguile/load.h (scm_parse_path_with_ellipsis): Add prototype.
>
> * doc/ref/api-evaluation.texi (Load Paths): Add docs.
> ---
> doc/ref/api-evaluation.texi | 9 +++++++++
> libguile/load.c | 31 +++++++++++++++++++++++++++++--
> libguile/load.h | 1 +
> 3 files changed, 39 insertions(+), 2 deletions(-)
[...]
> +a list and return the resulting list with @var{base} (a list) spliced in
> +place of the @code{...} path component, if present, or else @var{base}
> +is added to the end. If @var{path} is @code{#f}, @var{base} is
> +returned.
Looks clean to me.
> +#define FUNC_NAME s_scm_parse_path_with_ellipsis
> +{
> + SCM ellipsis = scm_from_latin1_string ("...");
Use ‘SCM_SYMBOL’ instead.
Modulo that, feel free to commit.
Thanks for working on this!
Ludo’.
PS: I’ve started updating NEWS.
next prev parent reply other threads:[~2012-11-28 23:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 3:18 Adding to the end of the load path Ian Price
2012-11-08 1:03 ` Andreas Rottmann
2012-11-11 7:50 ` Mark H Weaver
2012-11-11 19:02 ` Andreas Rottmann
2012-11-11 21:51 ` Mark H Weaver
2012-11-12 16:35 ` Bruce Korb
2012-11-13 21:04 ` Ludovic Courtès
2012-11-15 22:06 ` Andreas Rottmann
2012-11-15 22:37 ` Ludovic Courtès
2012-11-15 22:44 ` Mark H Weaver
2012-11-15 23:06 ` Ludovic Courtès
2012-11-16 0:10 ` Noah Lavine
2012-11-16 14:00 ` Noah Lavine
2012-11-16 18:06 ` Bruce Korb
2012-11-16 18:52 ` Mark H Weaver
2012-11-16 21:38 ` Noah Lavine
2012-11-28 23:12 ` [PATCH] Add parse-path-with-ellipsis, and use it for GUILE_LOAD_PATH et al Mark H Weaver
2012-11-28 23:46 ` Ludovic Courtès [this message]
2012-11-29 3:04 ` Mark H Weaver
2012-11-29 10:27 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehjd9tow.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guile-devel@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).