From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.devel Subject: Re: Support open-process and friends on MS-Windows Date: Sat, 25 Jun 2016 11:51:53 +0200 Message-ID: <87eg7lbnpi.fsf@pobox.com> References: <834m8i3off.fsf@gnu.org> <877fde958i.fsf@gnu.org> <83wple1zym.fsf@gnu.org> <83ziq9zl8l.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1466848357 25131 80.91.229.3 (25 Jun 2016 09:52:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 25 Jun 2016 09:52:37 +0000 (UTC) Cc: ludo@gnu.org, guile-devel@gnu.org To: Eli Zaretskii Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sat Jun 25 11:52:28 2016 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bGkGK-0006LY-8L for guile-devel@m.gmane.org; Sat, 25 Jun 2016 11:52:28 +0200 Original-Received: from localhost ([::1]:49171 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGkGJ-0002Ta-FU for guile-devel@m.gmane.org; Sat, 25 Jun 2016 05:52:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53703) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGkG2-0002TN-O4 for guile-devel@gnu.org; Sat, 25 Jun 2016 05:52:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGkG1-0006qK-QT for guile-devel@gnu.org; Sat, 25 Jun 2016 05:52:10 -0400 Original-Received: from pb-sasl2.pobox.com ([64.147.108.67]:54352 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGkFw-0006py-VB; Sat, 25 Jun 2016 05:52:05 -0400 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-sasl2.pobox.com (Postfix) with ESMTP id 65ED81CA25; Sat, 25 Jun 2016 05:52:02 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=m4j+dDTAAM1pfb4WMXjrr58y3rA=; b=tfudkA RoGY+XJ4KMYdcoAua/WWXNwzP6mBleSjG0V6i6NhrKuQVXld/F+1zc1ZEu843RdM qatLpdHVdWiaYo7qlEC+7raM7N4RL8ooP21I4+cr7le5dIBqRwHycOqLt69DgPLL hU3GpRHSGXpSjLOK78bGlHqfBNRzzQS1ESCCo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=ntWRGpeG7HNKLLLMUr3S92lN7UfGrhQH lk9c65CqrODtJux6c+vZ0NepRzzNSlkXZPiKDusnR62+0cHW4CyfRCsBmiqqi7KR 0VKO+J6zC/W+4uadFFG3iX+yV0lYM+ZvhvzNEA/nEn4slG5Bdi9SiBhcW2trD7Ll Kox8p2AiZUQ= Original-Received: from pb-sasl2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-sasl2.pobox.com (Postfix) with ESMTP id 503B31CA23; Sat, 25 Jun 2016 05:52:02 -0400 (EDT) Original-Received: from clucks (unknown [88.160.190.192]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-sasl2.pobox.com (Postfix) with ESMTPSA id 6BBC81CA21; Sat, 25 Jun 2016 05:52:01 -0400 (EDT) In-Reply-To: <83ziq9zl8l.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 25 Jun 2016 12:11:22 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-Pobox-Relay-ID: 770A4DB8-3ABA-11E6-BD99-28A6F1301B6D-02397024!pb-sasl2.pobox.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 64.147.108.67 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.org gmane.lisp.guile.devel:18429 Archived-At: On Sat 25 Jun 2016 11:11, Eli Zaretskii writes: > Here's the modified patch with the couple of changes requested in > response to the previous version: Great! I have two nits. One, if it is possible for you, please attach the patch in the format that "git format-patch" makes. That makes it easy to apply, otherwise I have to futz around with --author and I could accidentally fat-finger it and get it wrong. Secondly, please make w32-proc override the definitions of HAVE_GETPRIORITY, HAVE_SETPRIORITY, HAVE_SCHED_GETAFFINITY, and HAVE_SCHED_SETAFFINITY. That way you won't need this kind of change either: > -#if HAVE_GETPRIORITY > +#if HAVE_GETPRIORITY || defined __MINGW32__ If you've already discussed this with Ludovic and decided to go this way explicitly, please disregard this second nit. I will also wait a day or two for any comments from Ludovic before applying. Thanks again, great stuff! Andy