unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Kevin Ryde <user42@zip.com.au>
Subject: execl, execlp memory leak
Date: Wed, 25 Feb 2004 08:40:31 +1000	[thread overview]
Message-ID: <87d684hzj4.fsf@zip.com.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

        * posix.c (scm_execl, scm_execlp): Avoid memory leak under error throw.

This can be seen with for instance

	(while #t
	  (false-if-exception
	   (execl "nosuchprog")))

This would be for the 1.6 branch too.


[-- Attachment #2: posix.c.exec-leak.diff --]
[-- Type: text/plain, Size: 821 bytes --]

--- posix.c.~1.125.~	2004-02-22 07:54:37.000000000 +1000
+++ posix.c	2004-02-24 19:37:00.000000000 +1000
@@ -909,9 +909,13 @@
 #define FUNC_NAME s_scm_execl
 {
   char **execargv;
+  int save_errno;
   SCM_VALIDATE_STRING (1, filename);
   execargv = allocate_string_pointers (args);
   execv (SCM_STRING_CHARS (filename), execargv);
+  save_errno = errno;
+  free (execargv);
+  errno = save_errno;
   SCM_SYSERROR;
   /* not reached.  */
   return SCM_BOOL_F;
@@ -929,9 +933,13 @@
 #define FUNC_NAME s_scm_execlp
 {
   char **execargv;
+  int save_errno;
   SCM_VALIDATE_STRING (1, filename);
   execargv = allocate_string_pointers (args);
   execvp (SCM_STRING_CHARS (filename), execargv);
+  save_errno = errno;
+  free (execargv);
+  errno = save_errno;
   SCM_SYSERROR;
   /* not reached.  */
   return SCM_BOOL_F;

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/guile-devel

             reply	other threads:[~2004-02-24 22:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-24 22:40 Kevin Ryde [this message]
2004-02-25  7:33 ` execl, execlp memory leak Marius Vollmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d684hzj4.fsf@zip.com.au \
    --to=user42@zip.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).