automake 1.10 vs guile-func-name-check

* automake 1.10 vs guile-func-name-check
@ 2006-12-02 23:37 Kevin Ryde
  2006-12-14 20:16 ` Neil Jerram
  0 siblings, 1 reply; 2+ messages in thread
From: Kevin Ryde @ 2006-12-02 23:37 UTC (permalink / raw)

As mentioned on bug-guile, I switched to automake 1.10 in the
top-level makefile.  Among the new complaints is the bogosity of this
line in libguile/Makefile.am

	-(test -n "${AWK+set}" || AWK="@AWK@"; ${AWK} -f ./guile-func-name-check $<)

I expect it's meant to be "$${AWK:+set}" for a start, but even so I
don't think it has the intended effect.  AC_PROG_AWK puts an AWK=awk
in the generated Makefile, which will override a setting of $AWK in
the environment, which the "test" is apparently looking at.

I changed it to simply

	-$(AWK) -f ./guile-func-name-check $<

which I think is right, unless anyone can explain the intention of the
old bit.  You can still force to a particular awk with

	make AWK=my-groovy-awk

and that overrides other uses of $(AWK) like in the TAGS rule and
stuff.

_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread