From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: GUILE_MAX_HEAP_SIZE Date: Mon, 18 Aug 2008 17:55:21 +0200 Message-ID: <87d4k6mi6u.fsf@gnu.org> References: <87ej4tmf4m.fsf@gnu.org> <87d4k7e0s8.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1219075326 18971 80.91.229.12 (18 Aug 2008 16:02:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 18 Aug 2008 16:02:06 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Mon Aug 18 18:02:58 2008 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KV7BZ-0007qu-Fs for guile-devel@m.gmane.org; Mon, 18 Aug 2008 18:02:25 +0200 Original-Received: from localhost ([127.0.0.1]:45900 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KV7Ac-0001uI-Fu for guile-devel@m.gmane.org; Mon, 18 Aug 2008 12:01:26 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KV79N-0001Op-Gb for guile-devel@gnu.org; Mon, 18 Aug 2008 12:00:09 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KV79M-0001NB-4W for guile-devel@gnu.org; Mon, 18 Aug 2008 12:00:08 -0400 Original-Received: from [199.232.76.173] (port=36911 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KV79K-0001Ml-JL for guile-devel@gnu.org; Mon, 18 Aug 2008 12:00:06 -0400 Original-Received: from main.gmane.org ([80.91.229.2]:58766 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KV79K-0000Rc-2X for guile-devel@gnu.org; Mon, 18 Aug 2008 12:00:06 -0400 Original-Received: from root by ciao.gmane.org with local (Exim 4.43) id 1KV79G-0006hT-8C for guile-devel@gnu.org; Mon, 18 Aug 2008 16:00:02 +0000 Original-Received: from 193.50.110.219 ([193.50.110.219]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 18 Aug 2008 16:00:02 +0000 Original-Received: from ludo by 193.50.110.219 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 18 Aug 2008 16:00:02 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 33 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 193.50.110.219 X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 2 Fructidor an 216 de la =?iso-8859-1?Q?R=E9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 821D 815D 902A 7EAB 5CEE D120 7FBA 3D4F EB1F 5364 X-OS: i686-pc-linux-gnu User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) Cancel-Lock: sha1:dL7ofgfSIvRvI1xSF4pDQFbXdQ4= X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:7458 Archived-At: Han-Wen Nienhuys writes: > Ludovic Courtès escreveu: >> >> * 51ef99f7fa9fb766fbb48619fc5863ab9914591d >> Fix memory corruption issue with hell[] array: realloc/calloc need to >> factor in sizeof(scm_t_bits) >> >> - hell = scm_malloc (hell_size); >> + hell = scm_calloc (hell_size * sizeof(scm_t_bits)); >> >> Good catch, but it should read: >> >> hell = scm_calloc (hell_size * sizeof (*hell)); >> >> `sizeof (*hell)' is actually `sizeof (scm_t_bits *)', which is equal >> to `sizeof (scm_t_bits)', but using `sizeof (*hell)' is clearer and >> less error-prone. >> >> Besides, is that code only used when the one changes the class of an >> instance? How did you trigger it? > > valgrind. Fixed. Not quite actually: the "hell = scm_malloc (...)" bit is still broken. BTW, can you please avoid pushing small topic branches like "nit" and "dev/with-gnulib" to Savannah, as we can't distinguish them from "big" branches like "vm"? Thanks, Ludovic.