From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Neil Jerram Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] %nil-handling optimization and fixes v1 Date: Sun, 30 Aug 2009 10:18:04 +0100 Message-ID: <87d46dzmlv.fsf@arudy.ossau.uklinux.net> References: <20090709161043.GA2538@fibril.netris.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1251624018 2875 80.91.229.12 (30 Aug 2009 09:20:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 30 Aug 2009 09:20:18 +0000 (UTC) Cc: Mark H Weaver , guile-devel@gnu.org To: Andy Wingo Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sun Aug 30 11:20:11 2009 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Mhga2-0008Rr-Cf for guile-devel@m.gmane.org; Sun, 30 Aug 2009 11:20:11 +0200 Original-Received: from localhost ([127.0.0.1]:38325 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mhga1-0006nF-9y for guile-devel@m.gmane.org; Sun, 30 Aug 2009 05:20:09 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MhgY7-0006DA-IZ for guile-devel@gnu.org; Sun, 30 Aug 2009 05:18:11 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MhgY2-0006AK-Fe for guile-devel@gnu.org; Sun, 30 Aug 2009 05:18:10 -0400 Original-Received: from [199.232.76.173] (port=50087 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MhgY1-0006A3-Ro for guile-devel@gnu.org; Sun, 30 Aug 2009 05:18:06 -0400 Original-Received: from mail3.uklinux.net ([80.84.72.33]:59426) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MhgY1-0005Pw-H9 for guile-devel@gnu.org; Sun, 30 Aug 2009 05:18:05 -0400 Original-Received: from arudy (host86-152-99-133.range86-152.btcentralplus.com [86.152.99.133]) by mail3.uklinux.net (Postfix) with ESMTP id DA4DE1F6C12; Sun, 30 Aug 2009 10:18:04 +0100 (BST) Original-Received: from arudy.ossau.uklinux.net (arudy [127.0.0.1]) by arudy (Postfix) with ESMTP id 2C58C38021; Sun, 30 Aug 2009 10:18:04 +0100 (BST) In-Reply-To: (Andy Wingo's message of "Thu\, 23 Jul 2009 23\:38\:08 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:9202 Archived-At: Andy Wingo writes: >> scm_is_false_assume_not_lisp_nil scm_is_true_assume_not_lisp_nil >> scm_is_false_and_not_lisp_nil scm_is_true_or_lisp_nil >> scm_is_false_or_lisp_nil scm_is_true_and_not_lisp_nil >> >> scm_is_lisp_false scm_is_lisp_true >> >> scm_is_null_assume_not_lisp_nil >> scm_is_null_and_not_lisp_nil >> scm_is_null_or_lisp_nil >> >> scm_is_bool_and_not_lisp_nil >> scm_is_bool_or_lisp_nil > > These are terrible names. But they seem to be the best names for the > concepts we're trying to express. I don't understand all of them yet, > will wait for a review -- unless Neil takes care of that before I do ;-) I actually feel quite comfortable with them, now that I've read the patch carefully. Mark's comments above the macro definitions seem helpful and sufficient to me. Regards, Neil