From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: %module-public-interface Date: Tue, 30 Mar 2010 23:52:01 +0200 Message-ID: <87d3ylv5oe.fsf@gnu.org> References: <87zl1pv89p.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: dough.gmane.org 1269985950 13603 80.91.229.12 (30 Mar 2010 21:52:30 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 30 Mar 2010 21:52:30 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Tue Mar 30 23:52:26 2010 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NwjMG-0004If-NR for guile-devel@m.gmane.org; Tue, 30 Mar 2010 23:52:25 +0200 Original-Received: from localhost ([127.0.0.1]:40658 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NwjMG-0005QK-9m for guile-devel@m.gmane.org; Tue, 30 Mar 2010 17:52:24 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NwjMC-0005OB-S6 for guile-devel@gnu.org; Tue, 30 Mar 2010 17:52:20 -0400 Original-Received: from [140.186.70.92] (port=40243 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NwjMB-0005Nf-9R for guile-devel@gnu.org; Tue, 30 Mar 2010 17:52:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NwjM8-00053I-8O for guile-devel@gnu.org; Tue, 30 Mar 2010 17:52:19 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:54183) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NwjM7-00052x-T9 for guile-devel@gnu.org; Tue, 30 Mar 2010 17:52:16 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1NwjM5-0004EX-QC for guile-devel@gnu.org; Tue, 30 Mar 2010 23:52:13 +0200 Original-Received: from acces.bordeaux.inria.fr ([193.50.110.5]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 30 Mar 2010 23:52:13 +0200 Original-Received: from ludo by acces.bordeaux.inria.fr with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 30 Mar 2010 23:52:13 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 86 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: acces.bordeaux.inria.fr X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 10 Germinal an 218 de la =?iso-8859-1?Q?R=E9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) Cancel-Lock: sha1:simgSJ/djUcz6Vmp6ofaUMKtY1A= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:10127 Archived-At: Hello, Andy Wingo writes: > On Tue 30 Mar 2010 22:56, ludo@gnu.org (Ludovic Courtès) writes: > >>> I'm pretty sure that the submodule thing can be changed without any >>> problem. But it seems that the %module-public-interface is used >>> explicitly, at least by texmacs and lilypond. >> >> How do they use it? > > Linking to the evil empire: > > http://www.google.com/codesearch?hl=en&lr=&q=%25module-public-interface&sbtn=Search > http://www.google.com/codesearch?hl=en&lr=&q=%25module-public-interface+lang%3Ac%2B%2B&sbtn=Search Lilypond does: --8<---------------cut here---------------start------------->8--- mod = scm_call_0 (maker); scm_module_define (mod, ly_symbol2scm ("%module-public-interface"), mod); --8<---------------cut here---------------end--------------->8--- Solution: do something like: --8<---------------cut here---------------start------------->8--- #ifdef HAVE_SCM_SET_MODULE_PUBLIC_INTERFACE_X scm_set_module_public_interface_x (mod, mod); #else scm_module_define (mod, ly_symbol2scm ("%module-public-interface"), mod); #endif --8<---------------cut here---------------end--------------->8--- (We just need to add that function.) TeXmacs does: --8<---------------cut here---------------start------------->8--- (let* ((m (resolve-module which)) (m-public (module-ref m '%module-public-interface))) (module-map (lambda (sym var) sym) m-public))) --8<---------------cut here---------------end--------------->8--- and: --8<---------------cut here---------------start------------->8--- (let* ((m (resolve-module ',module)) (p (module-ref texmacs-user '%module-public-interface)) (r (module-ref p ',name #f))) (if (not r) (texmacs-error "lazy-define" ,(string-append "Could not retrieve " (symbol->string name)))) (apply r args)))))) --8<---------------cut here---------------end--------------->8--- Solution: use ‘resolve-interface’. Gossip does: --8<---------------cut here---------------start------------->8--- (append! (delq! '%module-public-interface (module-map (lambda (sym var) sym) mod)) (hash-fold (lambda (k v r) (cons k r)) '() blocks))) --8<---------------cut here---------------end--------------->8--- This snippet won’t see any difference. >> And we could add a ‘public-interface’ slot to ‘module-type’ and have >> ‘module-public-interface’ and ‘set-module-public-interface!’ refer to >> it; for backward compatibility we’d also initialize the >> ‘%module-public-interface’ binding. How does it sound? Actually the trick wouldn’t work in cases where the ‘%module-public-interface’ binding is mutated, as with Lilypond. Given this and the above examples, I’d suggest dropping that binding completely and sending patches to the Lilypond/TeXmacs people. What do you think? Thanks, Ludo’.