From: Andy Wingo <wingo@pobox.com>
To: ludo@gnu.org (Ludovic Courtès)
Cc: guile-devel@gnu.org
Subject: Re: build-lexical-var vs. -Wunused-variable
Date: Sun, 19 Feb 2012 22:08:26 +0100 [thread overview]
Message-ID: <87d39a1qgl.fsf@pobox.com> (raw)
In-Reply-To: <87ty2p4tct.fsf@gnu.org> ("Ludovic Courtès"'s message of "Fri, 17 Feb 2012 12:00:50 +0100")
On Fri 17 Feb 2012 12:00, ludo@gnu.org (Ludovic Courtès) writes:
> Commit f9685f437312ea790981373ddc375b2a26ba9c4f changes
> ‘build-lexical-var’ like this:
>
> (define-syntax-rule (build-lexical-var src id)
> - (gensym (string-append (symbol->string id) " ")))
> + (gensym (string-append (symbol->string id) "-")))
>
> This breaks a heuristic used in the ‘unused-variable’ pass, which is
> that identifiers containing white space are likely introduced by a macro
> and can be ignored in unused-variable reports (see ‘gensym?’ in
> ‘tree-il/analyze.scm’).
>
> OK to change it back?
How about we use `$' instead? I understand that's how Chez does it.
I'd really rather something that is printable without the #{#} syntax.
Andy
--
http://wingolog.org/
next prev parent reply other threads:[~2012-02-19 21:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 11:00 build-lexical-var vs. -Wunused-variable Ludovic Courtès
2012-02-19 21:08 ` Andy Wingo [this message]
2012-02-23 3:36 ` Mark H Weaver
2012-03-01 18:26 ` Ludovic Courtès
2013-01-16 10:40 ` Andy Wingo
2013-01-16 12:17 ` Ludovic Courtès
2013-01-16 12:27 ` Andy Wingo
2013-01-16 14:25 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d39a1qgl.fsf@pobox.com \
--to=wingo@pobox.com \
--cc=guile-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).