From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark H Weaver Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Do not scan for coding declarations in open-file Date: Thu, 31 Jan 2013 13:58:19 -0500 Message-ID: <87d2wlgoxg.fsf@tines.lan> References: <87zk0dq6sb.fsf@tines.lan> <8738y2x04e.fsf@gnu.org> <87zk01v45b.fsf@pobox.com> <878v7ahrfz.fsf_-_@tines.lan> <87mwvpwu2b.fsf@pobox.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1359658729 13198 80.91.229.3 (31 Jan 2013 18:58:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 31 Jan 2013 18:58:49 +0000 (UTC) Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , guile-devel@gnu.org To: Andy Wingo Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Thu Jan 31 19:59:05 2013 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U0zLg-0004ww-Nw for guile-devel@m.gmane.org; Thu, 31 Jan 2013 19:59:00 +0100 Original-Received: from localhost ([::1]:60737 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U0zLO-0002aj-Bp for guile-devel@m.gmane.org; Thu, 31 Jan 2013 13:58:42 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:60285) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U0zLL-0002aT-Eo for guile-devel@gnu.org; Thu, 31 Jan 2013 13:58:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U0zLJ-0001Z7-37 for guile-devel@gnu.org; Thu, 31 Jan 2013 13:58:39 -0500 Original-Received: from world.peace.net ([96.39.62.75]:59404) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U0zLI-0001Z2-Ur; Thu, 31 Jan 2013 13:58:37 -0500 Original-Received: from 209-6-91-212.c3-0.smr-ubr1.sbo-smr.ma.cable.rcn.com ([209.6.91.212] helo=tines.lan) by world.peace.net with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1U0zLB-0003Bx-Ss; Thu, 31 Jan 2013 13:58:30 -0500 In-Reply-To: <87mwvpwu2b.fsf@pobox.com> (Andy Wingo's message of "Thu, 31 Jan 2013 11:00:44 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 96.39.62.75 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:15657 Archived-At: Hi Andy, Andy Wingo writes: > The patch looks good to me but I am concerned about the behavior > change, and that it is inconvenient to get the previous behavior. > > My instinct is that we should not merge this patch without including a > way to enable the coding sniff; which seems to mean adding keywords or > somehow extending the arguments of: > > open-file > with-input-from-file > with-output-to-file > call-with-output-file > call-with-input-file > open-input-file I'd be glad to do this. I've long wanted these to accept keyword arguments for encoding and binary mode. We could also have a keyword to ask Guile to guess the encoding. This could be used to simplify the code used in 'compile-file' etc. We could also add a fluid to specify whether 'open-file' should try to guess the encoding, if that helps. What do you think? Mark