From: Mark H Weaver <mhw@netris.org>
To: Andy Wingo <wingo@pobox.com>
Cc: "Ludovic Courtès" <ludo@gnu.org>, guile-devel@gnu.org
Subject: Re: Adding new information to scm_t_port (was Re: always O_BINARY?)
Date: Tue, 05 Mar 2013 13:55:31 -0500 [thread overview]
Message-ID: <87d2vdekws.fsf@tines.lan> (raw)
In-Reply-To: <87y5e8stst.fsf@pobox.com> (Andy Wingo's message of "Thu, 28 Feb 2013 09:53:54 +0100")
Andy Wingo <wingo@pobox.com> writes:
> On Thu 28 Feb 2013 04:24, Mark H Weaver <mhw@netris.org> writes:
>
>> Instead of having 'input_cd' and 'output_cd' point directly to the
>> platform's iconv_t structures, let's have them point to our own internal
>> structure(s) that hold the needed transcoder state. This could include
>> things like the state for internally-implement encoding(s) (e.g. UTF-8
>> BOM handling), EOL style, and iconv_t pointer(s) if appropriate.
>
> Great idea.
>
> I would call it a generic "port-private" data structure; it is not
> limited to transcoder state.
>
> struct scm_t_port_private;
> #define SCM_I_PORT_PRIVATE ((struct scm_t_port_private*)((ptob)->input_cd))
Sounds good to me. I'll include something like this in my next revision
of BOM-handling patches, which I hope to post soon.
Thanks,
Mark
next prev parent reply other threads:[~2013-03-05 18:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-24 11:39 always O_BINARY? Andy Wingo
2013-02-24 12:08 ` Neil Jerram
2013-02-24 16:55 ` Mike Gran
2013-02-24 21:17 ` Ludovic Courtès
2013-02-28 3:24 ` Adding new information to scm_t_port (was Re: always O_BINARY?) Mark H Weaver
2013-02-28 8:53 ` Andy Wingo
2013-02-28 11:04 ` Ludovic Courtès
2013-02-28 13:09 ` Andy Wingo
2013-03-01 9:03 ` Ludovic Courtès
2013-03-05 18:55 ` Mark H Weaver [this message]
2013-03-27 20:00 ` [PATCH] Add private port structure, and move iconv descriptors there Mark H Weaver
2013-03-27 20:28 ` Ludovic Courtès
2013-03-27 20:51 ` Andy Wingo
2013-03-27 21:11 ` Mark H Weaver
2013-03-31 7:52 ` [PATCH] Add internal-only port structure; " Mark H Weaver
2013-03-31 13:20 ` Ludovic Courtès
2013-03-31 15:23 ` Mark H Weaver
2013-03-31 22:06 ` Ludovic Courtès
2013-04-01 18:57 ` Andy Wingo
2013-04-01 20:03 ` Mark H Weaver
2013-04-01 20:54 ` Andy Wingo
2013-04-01 21:04 ` Andy Wingo
2013-03-31 19:44 ` [PATCH] Add private port structure, and " Mark H Weaver
2013-03-31 22:08 ` Ludovic Courtès
2013-04-01 19:04 ` Andy Wingo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2vdekws.fsf@tines.lan \
--to=mhw@netris.org \
--cc=guile-devel@gnu.org \
--cc=ludo@gnu.org \
--cc=wingo@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).