unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: guile-devel@gnu.org
Subject: Re: [PATCH] Print the faulty object upon invalid-keyword errors.
Date: Tue, 04 Jun 2013 12:06:28 +0200	[thread overview]
Message-ID: <87d2s2b36j.fsf@gnu.org> (raw)
In-Reply-To: 87wqqafi4t.fsf@pobox.com

Andy Wingo <wingo@pobox.com> skribis:

> LGTM with a nit.
>
> On Tue 04 Jun 2013 00:33, ludo@gnu.org writes:
>
>> +  (define (keyword-error-printer port key args default-printer)
>> +    (let ((message (cadr args))
>> +          (faulty  (car (cadddr args)))) ; i won't do it again, i promise
>> +      (format port "~a: ~s" message faulty)))
>> +
>
> Capitalization ;-)

Ah, sorry about that one; will fix.  ;-)

Ludo’.




  reply	other threads:[~2013-06-04 10:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-03 22:33 [PATCH] Print the faulty object upon invalid-keyword errors ludo
2013-06-04  7:29 ` Andy Wingo
2013-06-04 10:06   ` Ludovic Courtès [this message]
2013-06-04 13:52 ` Mark H Weaver
2013-06-04 22:28   ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d2s2b36j.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guile-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).