From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Marius Vollmer Newsgroups: gmane.lisp.guile.devel Subject: Re: [Patch] SRFI-13 string-tokenize is wrong Date: 24 Apr 2002 21:58:23 +0200 Sender: guile-devel-admin@gnu.org Message-ID: <87bsc8oom8.fsf@zagadka.ping.de> References: NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1019678241 743 127.0.0.1 (24 Apr 2002 19:57:21 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Wed, 24 Apr 2002 19:57:21 +0000 (UTC) Cc: Martin Grabmueller , guile-devel@gnu.org, haus@lambda.math.uni-magdeburg.de Return-path: Original-Received: from fencepost.gnu.org ([199.232.76.164]) by main.gmane.org with esmtp (Exim 3.33 #1 (Debian)) id 170StF-0000Bs-00 for ; Wed, 24 Apr 2002 21:57:21 +0200 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 170St2-0002Q7-00; Wed, 24 Apr 2002 15:57:08 -0400 Original-Received: from dialin.speedway42.dip97.dokom.de ([195.138.42.97] helo=zagadka.ping.de) by fencepost.gnu.org with smtp (Exim 3.34 #1 (Debian)) id 170Sql-0002IL-00 for ; Wed, 24 Apr 2002 15:54:47 -0400 Original-Received: (qmail 11879 invoked by uid 1000); 24 Apr 2002 19:58:23 -0000 Original-To: Matthias Koeppe In-Reply-To: Original-Lines: 24 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2 Errors-To: guile-devel-admin@gnu.org X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.0.9 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Developers list for Guile, the GNU extensibility library List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.lisp.guile.devel:504 X-Report-Spam: http://spam.gmane.org/gmane.lisp.guile.devel:504 Matthias Koeppe writes: > Hi, > > the Guile implementation of SRFI-13 `string-tokenize' gets the meaning > of the `token-set' argument wrong. Yep, good catch. However, your patch did not make an unspecified token-set equivalent to char-set:graphic, but to (char-set-complement char-set:whitespace). Could you update your patch accordingly? Thanks! > I suggest fixing this bug in both the stable and the unstable branch, > so that incorrect uses of `string-tokenize' in user code are avoided. Yes, I have recorded this as bug 'string-tokenize-is-wrong' and tagged it as release critical. (I know this might be controversial. My argument is that in the rare case where we do have a standard to conform to, and we violate it so spectacularly, and the fix is so easy, then it is release critical.) _______________________________________________ Guile-devel mailing list Guile-devel@gnu.org http://mail.gnu.org/mailman/listinfo/guile-devel