From: Marius Vollmer <mvo@zagadka.ping.de>
Cc: Martin Grabmueller <mgrabmue@cs.tu-berlin.de>,
guile-devel@gnu.org, haus@lambda.math.uni-magdeburg.de
Subject: Re: [Patch] SRFI-13 string-tokenize is wrong
Date: 24 Apr 2002 21:58:23 +0200 [thread overview]
Message-ID: <87bsc8oom8.fsf@zagadka.ping.de> (raw)
In-Reply-To: <uw5henlwuxd.fsf@lambda.math.uni-magdeburg.de>
Matthias Koeppe <mkoeppe@mail.Math.Uni-Magdeburg.De> writes:
> Hi,
>
> the Guile implementation of SRFI-13 `string-tokenize' gets the meaning
> of the `token-set' argument wrong.
Yep, good catch. However, your patch did not make an unspecified
token-set equivalent to char-set:graphic, but to (char-set-complement
char-set:whitespace).
Could you update your patch accordingly?
Thanks!
> I suggest fixing this bug in both the stable and the unstable branch,
> so that incorrect uses of `string-tokenize' in user code are avoided.
Yes, I have recorded this as bug 'string-tokenize-is-wrong' and tagged
it as release critical.
(I know this might be controversial. My argument is that in the rare
case where we do have a standard to conform to, and we violate it so
spectacularly, and the fix is so easy, then it is release critical.)
_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/guile-devel
next prev parent reply other threads:[~2002-04-24 19:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-12 17:35 [Patch] SRFI-13 string-tokenize is wrong Matthias Koeppe
2002-04-24 19:58 ` Marius Vollmer [this message]
2002-04-26 8:27 ` Matthias Koeppe
2002-04-26 18:18 ` Marius Vollmer
2002-04-29 9:21 ` Matthias Koeppe
2002-05-06 18:54 ` Marius Vollmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bsc8oom8.fsf@zagadka.ping.de \
--to=mvo@zagadka.ping.de \
--cc=guile-devel@gnu.org \
--cc=haus@lambda.math.uni-magdeburg.de \
--cc=mgrabmue@cs.tu-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).