From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludovic.courtes@laas.fr (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Marking weak alist vectors, epilogue Date: Tue, 10 Jan 2006 09:21:49 +0100 Organization: LAAS-CNRS Message-ID: <87bqyksdb6.fsf@laas.fr> References: <87y83z3vh5.fsf@laas.fr> <4371CF46.4010708@xs4all.nl> <87y83xkcq6.fsf@laas.fr> <87sltny8dh.fsf_-_@laas.fr> <87zmm53152.fsf_-_@laas.fr> <87ace5jj3x.fsf@ossau.uklinux.net> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1136885159 6162 80.91.229.2 (10 Jan 2006 09:25:59 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 10 Jan 2006 09:25:59 +0000 (UTC) Cc: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Tue Jan 10 10:25:55 2006 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EwFlL-00083z-Dr for guile-devel@m.gmane.org; Tue, 10 Jan 2006 10:25:55 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EwFmJ-00087h-3c for guile-devel@m.gmane.org; Tue, 10 Jan 2006 04:26:55 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EwEnc-0002FP-Va for guile-devel@gnu.org; Tue, 10 Jan 2006 03:24:13 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EwEnX-0002F2-VG for guile-devel@gnu.org; Tue, 10 Jan 2006 03:24:11 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EwEnW-0002Er-0l for guile-devel@gnu.org; Tue, 10 Jan 2006 03:24:06 -0500 Original-Received: from [140.93.0.15] (helo=laas.laas.fr) by monty-python.gnu.org with esmtp (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.34) id 1EwEpv-0000Z5-Sd for guile-devel@gnu.org; Tue, 10 Jan 2006 03:26:36 -0500 Original-Received: by laas.laas.fr (8.13.1/8.13.4) with SMTP id k0A8LxVk008479; Tue, 10 Jan 2006 09:22:01 +0100 (CET) Original-To: Neil Jerram X-URL: http://www.laas.fr/~lcourtes/ X-Revolutionary-Date: 21 =?iso-8859-1?Q?Niv=F4se?= an 214 de la =?iso-8859-1?Q?R=E9volution?= X-PGP-Key-ID: 0xEB1F5364 X-PGP-Key: http://www.laas.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 821D 815D 902A 7EAB 5CEE D120 7FBA 3D4F EB1F 5364 X-OS: powerpc-unknown-linux-gnu Mail-Followup-To: Neil Jerram , guile-devel@gnu.org In-Reply-To: <87ace5jj3x.fsf@ossau.uklinux.net> (Neil Jerram's message of "Mon, 09 Jan 2006 19:29:06 +0000") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux) X-Spam-Score: 0 () X-Scanned-By: MIMEDefang at CNRS-LAAS X-MIME-Autoconverted: from 8bit to quoted-printable by laas.laas.fr id k0A8LxVk008479 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:5582 Archived-At: Neil Jerram writes: > ludovic.courtes@laas.fr (Ludovic Court=E8s) writes: > >> --- orig/libguile/properties.c >> +++ mod/libguile/properties.c >> @@ -125,6 +125,7 @@ >> scm_init_properties () >> { >> scm_properties_whash =3D scm_make_weak_key_hash_table (SCM_UNDEFINE= D); >> + scm_properties_whash =3D scm_permanent_object (scm_properties_whash= ); >> #include "libguile/properties.x" >> } > > What is the symptom of the fact that we are currently missing this > line? You mean: does it actually yield a fault at run-time? Well, it doesn't /seem/ to (i.e., I haven't identified any reproducible "bug" caused by this), but I think it /could/. ;-) All other such global variables are, understandably, explicitly made non-collectable. For instance, in `srcprop.c', SCM_SOURCE_WHASH is non-collectable because it is bound to a top-level binding. In `symbols.c', the SYMBOLS weak hash table is made permanent via a call to `scm_permanent_object ()'. Thanks, Ludovic. _______________________________________________ Guile-devel mailing list Guile-devel@gnu.org http://lists.gnu.org/mailman/listinfo/guile-devel