From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kevin Ryde Newsgroups: gmane.lisp.guile.devel Subject: Re: Serious bug in GUILE rational handling. Date: Sun, 24 Dec 2006 20:43:25 +1100 Message-ID: <87bqltd3ya.fsf@zip.com.au> References: <458D900F.1020108@xs4all.nl> <87slf66vw6.fsf@zip.com.au> <458DD284.2080906@xs4all.nl> NNTP-Posting-Host: dough.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1166953426 15918 80.91.229.10 (24 Dec 2006 09:43:46 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 24 Dec 2006 09:43:46 +0000 (UTC) Cc: schottstaedt@ccrma.stanford.edu, guile-devel@gnu.org, Jan Nieuwenhuizen Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sun Dec 24 10:43:44 2006 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by dough.gmane.org with esmtp (Exim 4.50) id 1GyPtO-0002GV-Rs for guile-devel@m.gmane.org; Sun, 24 Dec 2006 10:43:43 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GyPtO-0000nj-CD for guile-devel@m.gmane.org; Sun, 24 Dec 2006 04:43:42 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GyPtH-0000hr-CV for guile-devel@gnu.org; Sun, 24 Dec 2006 04:43:35 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GyPtC-0000UK-8D for guile-devel@gnu.org; Sun, 24 Dec 2006 04:43:34 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GyPtC-0000Tv-3V for guile-devel@gnu.org; Sun, 24 Dec 2006 04:43:30 -0500 Original-Received: from [61.8.2.231] (helo=mailout2.pacific.net.au) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GyPtA-0002KO-F0; Sun, 24 Dec 2006 04:43:28 -0500 Original-Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.2.163]) by mailout2.pacific.net.au (Postfix) with ESMTP id D57366E207; Sun, 24 Dec 2006 20:43:22 +1100 (EST) Original-Received: from localhost (ppp2751.dyn.pacific.net.au [61.8.39.81]) by mailproxy2.pacific.net.au (Postfix) with ESMTP id A6E5227404; Sun, 24 Dec 2006 20:43:23 +1100 (EST) Original-Received: from gg by localhost with local (Exim 4.63) (envelope-from ) id 1GyPt7-00071I-Ab; Sun, 24 Dec 2006 20:43:25 +1100 Original-To: hanwen@xs4all.nl Mail-Copies-To: never In-Reply-To: <458DD284.2080906@xs4all.nl> (Han-Wen Nienhuys's message of "Sun, 24 Dec 2006 02:06:12 +0100") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:6362 Archived-At: Han-Wen Nienhuys writes: > > I've added one (CVS HEAD) You can put tests in the branch for bugs fixed in the branch. Oh, and the popen.test was indeed my fault, indirectly. I stuck in a configure test for pipe(), because it doesn't exist on mingw, and that unintentionally enabled this bit of scm_display, write and write_char scm_prin1 (obj, port, 0); #ifdef HAVE_PIPE # ifdef EPIPE if (EPIPE == errno) scm_close_port (port); # endif #endif I've commented that out in the three places. I'm pretty sure it's not reliable to test errno at that point. I think popen.test had an EPIPE left from a long previous operation for instance, and it made scm_display close the check-guile.log file port. :( I can't tell where those lines came from, they're there in 1.6, but disabled on account of no HAVE_PIPE. Shows what you get for changing the configury I guess ... _______________________________________________ Guile-devel mailing list Guile-devel@gnu.org http://lists.gnu.org/mailman/listinfo/guile-devel