From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Jose A. Ortega Ruiz" Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Fix for `submodules' in (ice-9 session) (closes #30062) Date: Wed, 01 Sep 2010 01:11:25 +0200 Message-ID: <87bp8i2x9e.fsf@newton.homeunix.net> References: <1283257143-24354-1-git-send-email-jao@gnu.org> <87occi34ry.fsf@newton.homeunix.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1283299714 8262 80.91.229.12 (1 Sep 2010 00:08:34 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 1 Sep 2010 00:08:34 +0000 (UTC) Cc: Andy Wingo To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Sep 01 02:08:33 2010 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OqasS-0000cF-TI for guile-devel@m.gmane.org; Wed, 01 Sep 2010 02:08:33 +0200 Original-Received: from localhost ([127.0.0.1]:38875 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OqasR-0008Ot-Mq for guile-devel@m.gmane.org; Tue, 31 Aug 2010 20:08:31 -0400 Original-Received: from [140.186.70.92] (port=50677 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OqasK-0008OU-1F for guile-devel@gnu.org; Tue, 31 Aug 2010 20:08:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OqasB-0000ic-0k for guile-devel@gnu.org; Tue, 31 Aug 2010 20:08:23 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:38413) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OqasA-0000hm-RW for guile-devel@gnu.org; Tue, 31 Aug 2010 20:08:14 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Oqas6-0000TC-4x for guile-devel@gnu.org; Wed, 01 Sep 2010 02:08:10 +0200 Original-Received: from 83.50.71.238 ([83.50.71.238]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 01 Sep 2010 02:08:10 +0200 Original-Received: from jao by 83.50.71.238 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 01 Sep 2010 02:08:10 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 37 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 83.50.71.238 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Attribution: jao X-URL: Cancel-Lock: sha1:IoTF14rkZuIngpr5sjtv6yAOdec= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:10824 Archived-At: Hi again, On Tue, Aug 31 2010, Jose A. Ortega Ruiz wrote: > On Tue, Aug 31 2010, Andy Wingo wrote: > >> Hi, >> >> Can you submit a test please, also? > > I'm not quite sure what you want the test to be: the procedure > `submodules' is not exported by `(ice-9 session)', and there's no test > suite for the latter, so testing this change properly would mean > creating such a test suite, checking all directly affected exported > procedures. Those are `apropos-fold-exported' and > `apropos-fold-accessible'. > > Testing them is a bit involved, due to the cycles in the module tree [... blah blah blah ...] Please, ignore all the above stupid chatter. The fold functions are already testing for duplicates and there's no infinite loop anywhere. Sorry about my big mouth. (I'm still curious about the meaning of the modules with gensyms as names, though.) So, i'll write indirect tests for `submodules' by testing `apropos-fold-exported' and `apropos-fold-all' (i didn't even get the name right!). Would that work for you? Thanks, jao -- "I didn't do it, and I'll never do it again." -Derrik Weeks