From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: PEG Parser Date: Mon, 17 Jan 2011 22:32:22 +0100 Message-ID: <87bp3fi5cp.fsf@gnu.org> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: dough.gmane.org 1295300122 25720 80.91.229.12 (17 Jan 2011 21:35:22 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 17 Jan 2011 21:35:22 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Mon Jan 17 22:35:16 2011 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PewjM-0001ge-HU for guile-devel@m.gmane.org; Mon, 17 Jan 2011 22:35:16 +0100 Original-Received: from localhost ([127.0.0.1]:58252 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PewjL-0003zq-SY for guile-devel@m.gmane.org; Mon, 17 Jan 2011 16:35:15 -0500 Original-Received: from [140.186.70.92] (port=49617 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PewjE-0003zl-TZ for guile-devel@gnu.org; Mon, 17 Jan 2011 16:35:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PewjE-0005ED-1o for guile-devel@gnu.org; Mon, 17 Jan 2011 16:35:08 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]:36196) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PewjD-0005E9-MU for guile-devel@gnu.org; Mon, 17 Jan 2011 16:35:07 -0500 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1PewjA-0001Zt-WC for guile-devel@gnu.org; Mon, 17 Jan 2011 22:35:04 +0100 Original-Received: from yoda.fdn.fr ([80.67.169.18]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 17 Jan 2011 22:35:04 +0100 Original-Received: from ludo by yoda.fdn.fr with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 17 Jan 2011 22:35:04 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 33 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: yoda.fdn.fr X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 28 =?iso-8859-1?Q?Niv=F4se?= an 219 de la =?iso-8859-1?Q?R=E9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.2 (gnu/linux) Cancel-Lock: sha1:kXzNyKQvsqWnGrkWPurnOGXxX98= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:11317 Archived-At: Hi! Thanks for looking into this! Perhaps Andy has some insight to share, too? Noah Lavine writes: > First of all, it passes its test suite. This is pretty good, because > its test suite includes a grammar for itself, a grammar for basic > mathematical equations, and a grammar for parsing /etc/passwd files. > These all seem like good examples of things you'd want to parse. While these are nice, small unit tests targeting specific parts of PEG would seem useful to me, as in the rest of Guile. This may not be blocking, though. [...] > The only thing that seemed really weird is the macro safe-bind, which > basically reimplements hygienic macros. It's used all over the place > in the function-generating code. I also saw a couple of lines that > were too long, but not many, and the whole thing could be split into a > few modules, but it's not that long the way it is, so neither of those > seem like big issues. It could also stand to have a bigger test suite > (as the test suite itself says). “./check-guile --coverage peg.test” can be used to measure code coverage, normally. I agree that PEG could be useful. Thanks, Ludo’.