From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Fix non-portable usage of `isinf' in `max' and `min' Date: Thu, 03 Feb 2011 14:07:15 +0100 Message-ID: <87bp2t9sho.fsf@gnu.org> References: <87zkqeu19q.fsf@yeeloong.netris.org> <87pqrat8yl.fsf@yeeloong.netris.org> <87lj1yt0it.fsf_-_@yeeloong.netris.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: dough.gmane.org 1296738475 11690 80.91.229.12 (3 Feb 2011 13:07:55 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 3 Feb 2011 13:07:55 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Thu Feb 03 14:07:51 2011 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PkyuZ-0005PZ-4B for guile-devel@m.gmane.org; Thu, 03 Feb 2011 14:07:48 +0100 Original-Received: from localhost ([127.0.0.1]:48778 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PkyuV-0007oU-H6 for guile-devel@m.gmane.org; Thu, 03 Feb 2011 08:07:43 -0500 Original-Received: from [140.186.70.92] (port=41698 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PkyuO-0007ld-VU for guile-devel@gnu.org; Thu, 03 Feb 2011 08:07:38 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PkyuJ-00044O-BG for guile-devel@gnu.org; Thu, 03 Feb 2011 08:07:35 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]:32819) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PkyuJ-00044B-3J for guile-devel@gnu.org; Thu, 03 Feb 2011 08:07:31 -0500 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1PkyuG-0005I6-4Z for guile-devel@gnu.org; Thu, 03 Feb 2011 14:07:28 +0100 Original-Received: from 193.50.110.208 ([193.50.110.208]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 03 Feb 2011 14:07:28 +0100 Original-Received: from ludo by 193.50.110.208 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 03 Feb 2011 14:07:28 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 14 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 193.50.110.208 X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 15 =?iso-8859-1?Q?Pluvi=F4se?= an 219 de la =?iso-8859-1?Q?R=E9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.2 (gnu/linux) Cancel-Lock: sha1:lIT7wFMXyEBoW0pXqAH71n6LgWo= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 80.91.229.12 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:11531 Archived-At: Hello! And thanks for the patch stream and quick fixes! :-) Mark H Weaver writes: > Ah, I was using a non-portable extension of isinf(x) to determine the > sign of the infinity. This patch should fix it. We use Gnulib’s ‘isinf’ module. It could be that it’s buggy, or it could be improved to handle this specific case, in which it would be nice to share with bug-gnulib@gnu.org. Ludo’.