From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Add private port structure, and move iconv descriptors there Date: Mon, 01 Apr 2013 21:04:37 +0200 Message-ID: <87bo9ydqd6.fsf@pobox.com> References: <87vc9ij5z0.fsf@pobox.com> <87fw0l2yyk.fsf@gnu.org> <877gltxgrg.fsf_-_@tines.lan> <87y5e8stst.fsf@pobox.com> <87d2vdekws.fsf@tines.lan> <87d2uk62a0.fsf_-_@tines.lan> <87a9poin2d.fsf@pobox.com> <8738vb5p7x.fsf@tines.lan> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1364843094 19786 80.91.229.3 (1 Apr 2013 19:04:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 1 Apr 2013 19:04:54 +0000 (UTC) Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , guile-devel@gnu.org To: Mark H Weaver Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Mon Apr 01 21:05:21 2013 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UMk2c-0006Mv-E1 for guile-devel@m.gmane.org; Mon, 01 Apr 2013 21:05:14 +0200 Original-Received: from localhost ([::1]:58150 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMk2D-0005LF-Ne for guile-devel@m.gmane.org; Mon, 01 Apr 2013 15:04:49 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMk2A-0005L9-Az for guile-devel@gnu.org; Mon, 01 Apr 2013 15:04:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UMk26-0001yH-J2 for guile-devel@gnu.org; Mon, 01 Apr 2013 15:04:46 -0400 Original-Received: from a-pb-sasl-quonix.pobox.com ([208.72.237.25]:38166 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMk26-0001xt-CB; Mon, 01 Apr 2013 15:04:42 -0400 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id 06345B3E2; Mon, 1 Apr 2013 15:04:41 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=7OUwscQpCyBjZjS9RENfgmpqIaA=; b=hy3MSw HbU4Nk+/05iPF1DLvDnPAfCQ8H7HwPiYAVpMPRJQ/Q4Xe41x21amhL5Em8IU4i/X UgAo6Co22JXPVyidvY2/eVmNxNwZwlgm7RLUS1jfVLaiWB6RVmQWQnw3f+bNadqo 7z0VNe/1GVih6EVfNr23KZe+Mympteg8tLmGk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=TamcmQ5QgOHEH35F46fXljIvpDafuzch C91wUk7OBXoGFxQwFUdw2hCOiEO2hwIL0YfwYN5975BnDxOntYgrz0RE46Hz53EK PfwBqwisMmEB5y0Y44tnpgrNxC/A0NFnGsne6d9m3H95loq9wluZAq2xLkbrONEn k5u18eDMIDU= Original-Received: from a-pb-sasl-quonix.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id F2F2DB3E1; Mon, 1 Apr 2013 15:04:40 -0400 (EDT) Original-Received: from badger (unknown [88.160.190.192]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTPSA id 70780B3E0; Mon, 1 Apr 2013 15:04:40 -0400 (EDT) In-Reply-To: <8738vb5p7x.fsf@tines.lan> (Mark H. Weaver's message of "Sun, 31 Mar 2013 15:44:18 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) X-Pobox-Relay-ID: 016F3ED2-9AFF-11E2-BBCF-D36F0E5B5709-02397024!a-pb-sasl-quonix.pobox.com X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 208.72.237.25 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:16095 Archived-At: On Sun 31 Mar 2013 21:44, Mark H Weaver writes: > + { > + GC_finalization_proc prev_finalizer; > + GC_PTR prev_finalization_data; > + > + /* Register a finalizer to close the descriptors. */ > + GC_REGISTER_FINALIZER_NO_ORDER (id, finalize_iconv_descriptors, 0, > + &prev_finalizer, &prev_finalization_data); > + } Here we really want 6978c673393a960d7caf604b8c72ff2b5fe0f4ec; committed as 75ba64d6797f5857cc9885eb753126119a8c8b68 in stable-2.0, but probably needs to be manually reapplied here. Otherwise looks great to me. -- http://wingolog.org/